Clean up update-gomod.sh script#256
Open
dabradley wants to merge 1 commit intokubernetes-sigs:developmentfrom
Open
Clean up update-gomod.sh script#256dabradley wants to merge 1 commit intokubernetes-sigs:developmentfrom
dabradley wants to merge 1 commit intokubernetes-sigs:developmentfrom
Conversation
k8s-ci-robot
added
the
kind/cleanup
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dabradley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
There was a problem hiding this comment.
Pull request overview
This PR cleans up the update-gomod.sh script by fixing shell linter issues and adding missing go mod commands. The script helps developers upgrade Kubernetes dependencies by handling the required 'replace' statements in the go.mod file.
Changes:
- Improved error messages with example usage
- Replaced command substitution with
mapfilefor better array handling - Added proper variable quoting for shell best practices
- Added missing go mod commands (get, download, tidy, vendor) for complete dependency management
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 21041158348Details
💛 - Coveralls |
dabradley
force-pushed
the
clean-update-gomod-script
branch
from
1d8707a to
f6ea04b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This script allows developers to upgrade the kubernetes dependencies (since their versioning is effectively broken and requires explicit 'replace' statements in the go.mod file). This PR fixes some linter issues and ensures that all necessary go mod commands are called.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: