Add cluster ping to publish#258
Draft
dabradley wants to merge 1 commit intokubernetes-sigs:developmentfrom
Draft
Add cluster ping to publish#258dabradley wants to merge 1 commit intokubernetes-sigs:developmentfrom
dabradley wants to merge 1 commit intokubernetes-sigs:developmentfrom
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dabradley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
If the IP address for a cluster is not reachable, it takes a very long time for the mount to time out, holding up K8S operations and preventing quick deletion of incorrect volumes. This change adds ping operation to ensure that the node is able to communicate with the expected cluster before attempting the mount operation. The result is cached for 30 seconds to prevent overwhelming the API if many volumes are being published in a short period of time.
dabradley
force-pushed
the
add-cluster-ping
branch
from
e618d21 to
3be4b59
Compare
Pull Request Test Coverage Report for Build 21040971027Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the IP address for a cluster is not reachable, it takes a very long time for the mount to time out, holding up K8S operations and preventing quick deletion of incorrect volumes.
This change adds ping operation to ensure that the node is able to communicate with the expected cluster before attempting the mount operation. The result is cached for 30 seconds to prevent overwhelming the API if many volumes are being published in a short period of time.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: