feat: add allowSharedKeyAccess parameter

[specialforest]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows to provision dynamic storage accounts with shared key access disabled.

Which issue(s) this PR fixes:

Fixes #1462.

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:
Tested on AKS cluster by mounting dynamic PVC to a pod and writing a file.
Storage class spec:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: azureblob-fuse
reclaimPolicy: Delete
volumeBindingMode: Immediate
provisioner: blob.csi.azure.com
allowVolumeExpansion: true
parameters:
  skuName: Premium_LRS
  allowSharedKeyAccess: "false"
  storeAccountKey: "false"
  AzureStorageAuthType: msi
  AzureStorageIdentityClientID: <redacted>

Release note:

none

[k8s-ci-robot]

Welcome @specialforest!

It looks like this is your first PR to kubernetes-sigs/blob-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blob-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @specialforest. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[specialforest]

Need to add a unit test.

[andyzhangx]

allowSharedKeyAccess parameter needs to be added in azure cloud provider first

[andyzhangx]

allowSharedKeyAccess parameter needs to be added in azure cloud provider first

nvm, allowSharedKeyAccess is already added in azure cloud provider

[umagnus]

I think here should be !pointer.BoolDeref(allowSharedKeyAccess, true) since if we didn't give allowSharedKeyAccess the default is true

[andyzhangx]

yes, the default value is true

[specialforest]

Technically allowSharedKeyAccess is never nil here but let me refactor the code a little to make it more straightforward.

[andyzhangx]

/ok-to-test

[andyzhangx]

/retest

[andyzhangx]

/retest

[andyzhangx]

/retest

[andyzhangx]

/retest

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, specialforest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/cherrypick release-1.24

[andyzhangx]

/cherrypick release-1.23

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #1481

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@andyzhangx: #1470 failed to apply on top of branch "release-1.23":

Applying: feat: add allowSharedKeyAccess parameter
Applying: Add basic test
Applying: PR feedback
Using index info to reconstruct a base tree...
M	pkg/blob/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/blob/controllerserver.go
CONFLICT (content): Merge conflict in pkg/blob/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 PR feedback
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.