Skip to content

Conversation

steeling
Copy link
Contributor

Add basic grpc metrics to the CSI Driver

/kind feature

What this PR does / why we need it:

More metrics for deeper insights into performance of the driver

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @steeling!

It looks like this is your first PR to kubernetes-sigs/blob-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blob-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and cvvz July 31, 2024 16:16
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @steeling. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 31, 2024
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, steeling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit de91a86 into kubernetes-sigs:master Aug 1, 2024
22 checks passed
@andyzhangx
Copy link
Member

/cherrypick release-1.24

@k8s-infra-cherrypick-robot

@andyzhangx: #1523 failed to apply on top of branch "release-1.24":

Applying: feat: add grpcprom interceptor to export basic grpc metrics
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	vendor/github.com/golang/protobuf/jsonpb/decode.go
A	vendor/github.com/golang/protobuf/jsonpb/encode.go
A	vendor/github.com/golang/protobuf/jsonpb/json.go
M	vendor/golang.org/x/oauth2/internal/token.go
M	vendor/golang.org/x/oauth2/oauth2.go
M	vendor/golang.org/x/oauth2/token.go
A	vendor/google.golang.org/appengine/internal/api.go
A	vendor/google.golang.org/appengine/internal/api_classic.go
A	vendor/google.golang.org/appengine/internal/api_common.go
A	vendor/google.golang.org/appengine/internal/identity.go
A	vendor/google.golang.org/appengine/internal/identity_classic.go
A	vendor/google.golang.org/appengine/internal/identity_flex.go
A	vendor/google.golang.org/appengine/internal/identity_vm.go
A	vendor/google.golang.org/appengine/internal/main.go
A	vendor/google.golang.org/appengine/internal/main_vm.go
A	vendor/google.golang.org/appengine/internal/transaction.go
A	vendor/google.golang.org/appengine/urlfetch/urlfetch.go
M	vendor/google.golang.org/genproto/googleapis/api/annotations/client.pb.go
M	vendor/google.golang.org/grpc/balancer/balancer.go
A	vendor/google.golang.org/grpc/balancer_conn_wrappers.go
M	vendor/google.golang.org/grpc/binarylog/grpc_binarylog_v1/binarylog.pb.go
M	vendor/google.golang.org/grpc/clientconn.go
M	vendor/google.golang.org/grpc/codes/codes.go
M	vendor/google.golang.org/grpc/credentials/credentials.go
M	vendor/google.golang.org/grpc/credentials/tls.go
M	vendor/google.golang.org/grpc/dialoptions.go
M	vendor/google.golang.org/grpc/encoding/proto/proto.go
M	vendor/google.golang.org/grpc/health/grpc_health_v1/health.pb.go
M	vendor/google.golang.org/grpc/health/grpc_health_v1/health_grpc.pb.go
M	vendor/google.golang.org/grpc/internal/balancer/gracefulswitch/gracefulswitch.go
M	vendor/google.golang.org/grpc/internal/binarylog/method_logger.go
M	vendor/google.golang.org/grpc/internal/binarylog/sink.go
M	vendor/google.golang.org/grpc/internal/buffer/unbounded.go
M	vendor/google.golang.org/grpc/internal/channelz/funcs.go
A	vendor/google.golang.org/grpc/internal/channelz/id.go
M	vendor/google.golang.org/grpc/internal/channelz/logging.go
A	vendor/google.golang.org/grpc/internal/channelz/types.go
A	vendor/google.golang.org/grpc/internal/channelz/types_linux.go
A	vendor/google.golang.org/grpc/internal/channelz/types_nonlinux.go
A	vendor/google.golang.org/grpc/internal/channelz/util_linux.go
A	vendor/google.golang.org/grpc/internal/channelz/util_nonlinux.go
M	vendor/google.golang.org/grpc/internal/envconfig/envconfig.go
M	vendor/google.golang.org/grpc/internal/envconfig/xds.go
A	vendor/google.golang.org/grpc/internal/grpcrand/grpcrand.go
M	vendor/google.golang.org/grpc/internal/grpcsync/callback_serializer.go
M	vendor/google.golang.org/grpc/internal/idle/idle.go
M	vendor/google.golang.org/grpc/internal/internal.go
M	vendor/google.golang.org/grpc/internal/pretty/pretty.go
M	vendor/google.golang.org/grpc/internal/resolver/dns/dns_resolver.go
M	vendor/google.golang.org/grpc/internal/resolver/unix/unix.go
M	vendor/google.golang.org/grpc/internal/status/status.go
M	vendor/google.golang.org/grpc/internal/transport/controlbuf.go
M	vendor/google.golang.org/grpc/internal/transport/handler_server.go
M	vendor/google.golang.org/grpc/internal/transport/http2_client.go
M	vendor/google.golang.org/grpc/internal/transport/http2_server.go
M	vendor/google.golang.org/grpc/internal/transport/http_util.go
M	vendor/google.golang.org/grpc/internal/transport/proxy.go
M	vendor/google.golang.org/grpc/internal/transport/transport.go
A	vendor/google.golang.org/grpc/internal/xds_handshake_cluster.go
M	vendor/google.golang.org/grpc/metadata/metadata.go
M	vendor/google.golang.org/grpc/peer/peer.go
M	vendor/google.golang.org/grpc/picker_wrapper.go
A	vendor/google.golang.org/grpc/pickfirst.go
M	vendor/google.golang.org/grpc/resolver/manual/manual.go
M	vendor/google.golang.org/grpc/resolver/map.go
M	vendor/google.golang.org/grpc/resolver/resolver.go
A	vendor/google.golang.org/grpc/resolver_conn_wrapper.go
M	vendor/google.golang.org/grpc/rpc_util.go
M	vendor/google.golang.org/grpc/server.go
M	vendor/google.golang.org/grpc/service_config.go
M	vendor/google.golang.org/grpc/stream.go
M	vendor/google.golang.org/grpc/trace.go
M	vendor/google.golang.org/grpc/version.go
A	vendor/google.golang.org/grpc/vet.sh
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
CONFLICT (modify/delete): vendor/google.golang.org/grpc/vet.sh deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/grpc/vet.sh left in tree.
Auto-merging vendor/google.golang.org/grpc/version.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/version.go
Auto-merging vendor/google.golang.org/grpc/stream.go
Auto-merging vendor/google.golang.org/grpc/service_config.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/service_config.go
Auto-merging vendor/google.golang.org/grpc/server.go
Auto-merging vendor/google.golang.org/grpc/rpc_util.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/rpc_util.go
CONFLICT (add/add): Merge conflict in vendor/google.golang.org/grpc/resolver_wrapper.go
Auto-merging vendor/google.golang.org/grpc/resolver_wrapper.go
CONFLICT (add/add): Merge conflict in vendor/google.golang.org/grpc/resolver/dns/dns_resolver.go
Auto-merging vendor/google.golang.org/grpc/resolver/dns/dns_resolver.go
Auto-merging vendor/google.golang.org/grpc/picker_wrapper.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/picker_wrapper.go
Auto-merging vendor/google.golang.org/grpc/peer/peer.go
Auto-merging vendor/google.golang.org/grpc/internal/transport/transport.go
Auto-merging vendor/google.golang.org/grpc/internal/transport/http2_server.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/internal/transport/http2_server.go
Auto-merging vendor/google.golang.org/grpc/internal/transport/http2_client.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/internal/transport/http2_client.go
Auto-merging vendor/google.golang.org/grpc/internal/transport/controlbuf.go
CONFLICT (add/add): Merge conflict in vendor/google.golang.org/grpc/internal/resolver/dns/internal/internal.go
Auto-merging vendor/google.golang.org/grpc/internal/resolver/dns/internal/internal.go
Auto-merging vendor/google.golang.org/grpc/internal/resolver/dns/dns_resolver.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/internal/resolver/dns/dns_resolver.go
Auto-merging vendor/google.golang.org/grpc/internal/internal.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/internal/internal.go
CONFLICT (rename/rename): Rename "vendor/google.golang.org/grpc/internal/channelz/util_nonlinux.go"->"vendor/google.golang.org/grpc/internal/grpcutil/grpcutil.go" in branch "HEAD" rename "vendor/google.golang.org/grpc/internal/channelz/util_nonlinux.go"->"vendor/google.golang.org/grpc/internal/tcp_keepalive_others.go" in "feat: add grpcprom interceptor to export basic grpc metrics"
Auto-merging vendor/google.golang.org/grpc/internal/grpcutil/grpcutil.go and vendor/google.golang.org/grpc/internal/tcp_keepalive_others.go, both renamed from vendor/google.golang.org/grpc/internal/channelz/util_nonlinux.go
Auto-merging vendor/google.golang.org/grpc/internal/tcp_keepalive_others.go
CONFLICT (rename/rename): Rename "vendor/google.golang.org/grpc/internal/channelz/util_linux.go"->"vendor/google.golang.org/grpc/internal/grpcsync/oncefunc.go" in branch "HEAD" rename "vendor/google.golang.org/grpc/internal/channelz/util_linux.go"->"vendor/google.golang.org/grpc/trace_withtrace.go" in "feat: add grpcprom interceptor to export basic grpc metrics"
Auto-merging vendor/google.golang.org/grpc/internal/grpcsync/oncefunc.go and vendor/google.golang.org/grpc/trace_withtrace.go, both renamed from vendor/google.golang.org/grpc/internal/channelz/util_linux.go
Auto-merging vendor/google.golang.org/grpc/trace_withtrace.go
CONFLICT (modify/delete): vendor/google.golang.org/grpc/internal/grpcrand/grpcrand.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/grpc/internal/grpcrand/grpcrand.go left in tree.
Auto-merging vendor/google.golang.org/grpc/internal/envconfig/envconfig.go
Auto-merging vendor/google.golang.org/grpc/internal/channelz/syscall_nonlinux.go
Auto-merging vendor/google.golang.org/grpc/internal/channelz/syscall_linux.go
Auto-merging vendor/google.golang.org/grpc/internal/binarylog/method_logger.go
Auto-merging vendor/google.golang.org/grpc/internal/balancer/gracefulswitch/gracefulswitch.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/internal/balancer/gracefulswitch/gracefulswitch.go
CONFLICT (add/add): Merge conflict in vendor/google.golang.org/grpc/internal/balancer/gracefulswitch/config.go
Auto-merging vendor/google.golang.org/grpc/internal/balancer/gracefulswitch/config.go
Auto-merging vendor/google.golang.org/grpc/health/grpc_health_v1/health_grpc.pb.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/health/grpc_health_v1/health_grpc.pb.go
Auto-merging vendor/google.golang.org/grpc/health/grpc_health_v1/health.pb.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/health/grpc_health_v1/health.pb.go
Auto-merging vendor/google.golang.org/grpc/dialoptions.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/dialoptions.go
Auto-merging vendor/google.golang.org/grpc/credentials/tls.go
Auto-merging vendor/google.golang.org/grpc/credentials/credentials.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/credentials/credentials.go
Auto-merging vendor/google.golang.org/grpc/codes/codes.go
Auto-merging vendor/google.golang.org/grpc/clientconn.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/clientconn.go
Auto-merging vendor/google.golang.org/grpc/binarylog/grpc_binarylog_v1/binarylog.pb.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/binarylog/grpc_binarylog_v1/binarylog.pb.go
CONFLICT (add/add): Merge conflict in vendor/google.golang.org/grpc/balancer_wrapper.go
Auto-merging vendor/google.golang.org/grpc/balancer_wrapper.go
Auto-merging vendor/google.golang.org/grpc/balancer/pickfirst/pickfirst.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/balancer/pickfirst/pickfirst.go
Auto-merging vendor/google.golang.org/genproto/googleapis/api/annotations/client.pb.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/genproto/googleapis/api/annotations/client.pb.go
CONFLICT (modify/delete): vendor/google.golang.org/appengine/urlfetch/urlfetch.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/urlfetch/urlfetch.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/transaction.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/transaction.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/main_vm.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/main_vm.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/main.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/main.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/identity_vm.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/identity_vm.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/identity_flex.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/identity_flex.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/identity_classic.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/identity_classic.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/identity.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/identity.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/api_common.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/api_common.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/api_classic.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/api_classic.go left in tree.
CONFLICT (modify/delete): vendor/google.golang.org/appengine/internal/api.go deleted in HEAD and modified in feat: add grpcprom interceptor to export basic grpc metrics. Version feat: add grpcprom interceptor to export basic grpc metrics of vendor/google.golang.org/appengine/internal/api.go left in tree.
Auto-merging vendor/golang.org/x/oauth2/oauth2.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: add grpcprom interceptor to export basic grpc metrics
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants