Skip to content

feat: support blobStorageAccountType parameter in storage class or pv #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support blobStorageAccountType parameter in storage class or pv

usually we don't need this parameter setting in sc or pv since from blobfuse 2.4.2, the blobfuse2 driver would auto detect storage account type, while if user still wants to specify this account type in edge case, this PR will support this scenario:

AZURE_STORAGE_ACCOUNT_TYPE: Specifies the account type 'block' or 'adls'

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: support blobStorageAccountType parameter in storage class or pv

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from cvvz and feiskyer August 4, 2025 02:43
@andyzhangx andyzhangx removed the request for review from feiskyer August 4, 2025 05:13
@andyzhangx andyzhangx merged commit 9165dce into kubernetes-sigs:master Aug 4, 2025
20 of 21 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.26

@andyzhangx
Copy link
Member Author

/cherrypick release-1.25

@k8s-infra-cherrypick-robot

@andyzhangx: #2102 failed to apply on top of branch "release-1.26":

Applying: feat: support blobStorageAccountType parameter in storage class or pv
Using index info to reconstruct a base tree...
M	pkg/blob/blob.go
M	pkg/blob/nodeserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/blob/nodeserver.go
CONFLICT (content): Merge conflict in pkg/blob/nodeserver.go
Auto-merging pkg/blob/blob.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 feat: support blobStorageAccountType parameter in storage class or pv

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #2102 failed to apply on top of branch "release-1.25":

Applying: feat: support blobStorageAccountType parameter in storage class or pv
Using index info to reconstruct a base tree...
M	pkg/blob/blob.go
M	pkg/blob/controllerserver.go
M	pkg/blob/controllerserver_test.go
M	pkg/blob/nodeserver.go
M	test/e2e/dynamic_provisioning_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/dynamic_provisioning_test.go
CONFLICT (content): Merge conflict in test/e2e/dynamic_provisioning_test.go
Auto-merging pkg/blob/nodeserver.go
CONFLICT (content): Merge conflict in pkg/blob/nodeserver.go
Auto-merging pkg/blob/controllerserver_test.go
Auto-merging pkg/blob/controllerserver.go
Auto-merging pkg/blob/blob.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 feat: support blobStorageAccountType parameter in storage class or pv

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andyzhangx
Copy link
Member Author

/cherrypick release-1.26

@k8s-infra-cherrypick-robot

@andyzhangx: #2102 failed to apply on top of branch "release-1.26":

Applying: feat: support blobStorageAccountType parameter in storage class or pv
Using index info to reconstruct a base tree...
M	pkg/blob/blob.go
M	pkg/blob/nodeserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/blob/nodeserver.go
CONFLICT (content): Merge conflict in pkg/blob/nodeserver.go
Auto-merging pkg/blob/blob.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 feat: support blobStorageAccountType parameter in storage class or pv

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants