-
Notifications
You must be signed in to change notification settings - Fork 90
fix: support blobfuse2 install for GKE cos node #2125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes blobfuse2 installation support for Google Kubernetes Engine (GKE) Container-Optimized OS (COS) nodes by adding COS-specific handling to the installation scripts.
- Adds COS distribution detection and routing to the RHCOS installation script
- Configures COS-specific binary installation path (
/home/kubernetes/bin
) - Fixes variable quoting issues in shell scripts for better robustness
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
pkg/blobfuse-proxy/install-proxy.sh | Fixes variable quoting for KUBELET_PATH |
pkg/blobfuse-proxy/install-proxy-rhcos.sh | Adds COS support with configurable binary path and fixes variable quoting |
pkg/blobfuse-proxy/init.sh | Routes COS distribution to use RHCOS installation script |
/retest |
@andyzhangx: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: support blobfuse2 install for GKE cos node
Which issue(s) this PR fixes:
Fixes #2109
Requirements:
Special notes for your reviewer:
Release note: