Skip to content

fix: support blobfuse2 install for GKE cos node #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: support blobfuse2 install for GKE cos node

Which issue(s) this PR fixes:

Fixes #2109

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cvvz and feiskyer August 9, 2025 14:49
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2025
@andyzhangx andyzhangx requested a review from Copilot August 9, 2025 14:49
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 9, 2025
@andyzhangx andyzhangx removed request for feiskyer and cvvz August 9, 2025 14:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes blobfuse2 installation support for Google Kubernetes Engine (GKE) Container-Optimized OS (COS) nodes by adding COS-specific handling to the installation scripts.

  • Adds COS distribution detection and routing to the RHCOS installation script
  • Configures COS-specific binary installation path (/home/kubernetes/bin)
  • Fixes variable quoting issues in shell scripts for better robustness

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pkg/blobfuse-proxy/install-proxy.sh Fixes variable quoting for KUBELET_PATH
pkg/blobfuse-proxy/install-proxy-rhcos.sh Adds COS support with configurable binary path and fixes variable quoting
pkg/blobfuse-proxy/init.sh Routes COS distribution to use RHCOS installation script

@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-blob-csi-driver-external-e2e-nfs aa044b7 link true /test pull-blob-csi-driver-external-e2e-nfs
pull-blob-csi-driver-e2e-proxy aa044b7 link true /test pull-blob-csi-driver-e2e-proxy

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install-blobfuse-proxy init-container fails on GKE/COS nodes due to read-only filesystem
2 participants