Skip to content

Conversation

@t-lo
Copy link
Contributor

@t-lo t-lo commented Oct 17, 2025

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

This change adds support for Flatcar to the blobfuse installer. Changes are minimal; we're re-using the rhcos installer script and the gardenlinux paths.

Changes are minimal; we're re-using the rhcos installer script and the gardenlinux paths.

As Flatcar currently does not ship libfuse, we install it alongside blobfuse2, similar to what #2208 does for RHCOS.

Lastly, this change contains a fix for updating PATH in the blobfuse-proxy.service systemd service unit. Previously, the way PATH was modified led to the variable contents being overwritten instead of added to. See 0f30780 for details.

Special notes for your reviewer:

This change was verified by a test cluster deployment by @invidian . Pre-built container images for testing are available from https://github.com/flatcar-hub/blob-csi-driver/pkgs/container/blob-csi .

Release note:

* Installer: Added support for Flatcar Container Linux

t-lo added 3 commits October 17, 2025 17:01
This change adds support for Flatcar to the blobfuse installer.
Changes are minimal; we're re-using the rhcos installer script and the
gardenlinux paths.

As Flatcar currently does not ship libfuse, we install it alongside
blobfuse2.

Signed-off-by: Thilo Fromm <[email protected]>
The installer script wants to update the PATH variable to include
$BIN_PATH in blobfuse-proxs's systemd unit by setting:

Environment="PATH=<BIN_PATH>:$PATH"

BIN_PATH is evaluated in the installer script, and $PATH is escaped, to
be evaluated when the service unit runs.
However, environment variables like "$PATH" are NOT evaluated
by systemd in Environment="...". Quoting the documentation:

" Variable expansion is not performed inside the strings
  and the "$" character has no special meaning. "

https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#Environment

This effectively removes all other paths and sets PATH to ONLY <BIN_PATH>.
The resulting environment variable PATH contains the actual contents of
BIN_PATH and a literal '$PATH'.

This commit fixes that by wrapping ExecStart in bash -c '...' and
updating PATH there.
Signed-off-by: Thilo Fromm <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @t-lo!

It looks like this is your first PR to kubernetes-sigs/blob-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blob-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @t-lo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2025
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2025
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, t-lo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit cf6ddee into kubernetes-sigs:master Oct 18, 2025
22 checks passed
@andyzhangx
Copy link
Member

@t-lo could you also cherrypick this PR to release-1.33? thx

@t-lo
Copy link
Contributor Author

t-lo commented Oct 19, 2025

@andyzhangx I'd be happy to help! Could you please elaborate on release-1.33 ? I see release- branches for 1.23 to 1.27 but no 1.33?

@t-lo
Copy link
Contributor Author

t-lo commented Oct 19, 2025

@andyzhangx I was browsing closed PRs and saw that everything gets backported to 1.26 and 1.27, so I did the same:

Is this what you're looking for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants