Skip to content

feat: add telemetry as part of mount options for blobfuse mounts #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+120 −4
Open

feat: add telemetry as part of mount options for blobfuse mounts #2248

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7999704
chore: add telemetry as part of mount options for blobfuse mounts
mittachaitu Nov 10, 2025
2b4e9c8
fix: add telemetry to the flag only if protocol is fuse2
mittachaitu Nov 17, 2025
8d9b9fd
fix: move the tag adding logic inside blobfuse-proxy code
mittachaitu Nov 19, 2025
5c45e5b
fix: update telemtery tag and add Unit test for telemetry parsing
mittachaitu Nov 26, 2025
618aac5
fix: fix test case linting issue
mittachaitu Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/blob/nodeserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,10 @@ func (d *Driver) NodeStageVolume(ctx context.Context, req *csi.NodeStageVolumeRe
}

// Get mountOptions that the volume will be formatted and mounted with
if protocol == Fuse2 {
// Adding telemetry tag to know that blob is been mounted through AKS
mountFlags = util.JoinMountOptions(mountFlags, []string{fmt.Sprintf("--telemetry=azpartner-aks/%s", d.Version)})
Copy link
Member

@andyzhangx andyzhangx Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow the PR example here: #2024 since protocol may be empty here, and also check whether this option is already specified

Copy link
Member

@andyzhangx andyzhangx Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I think just use --telemetry=aks/%s is more straightfoward

Copy link
Author

@mittachaitu mittachaitu Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andy, I have moved the code to under pkg/blobfuse-proxy/server.go and if user specifies the option through StorageClass then we are appending above to telemetry option

ex: In below example user has provided telemetry as part of mount option...

mountOptions:
  - -o allow_other
  - --file-cache-timeout-in-seconds=120
  - --use-attr-cache=true
  - --cancel-list-on-mount-seconds=10  # prevent billing charges on mounting
  - -o attr_timeout=120
  - -o entry_timeout=120
  - -o negative_timeout=120
  - --telemetry=tire1

Then mount args to blobfuse2 will be (--telemetry=azpartner-aks/v1.28.0,normaltest)

 server.go:99] updated --telemetry tag in mount args: mount /var/lib/kubelet/plugins/kubernetes.io/csi/blob.csi.azure.com/d6b00230de0d40736dda3f197b49a4919bfb9b7512f4466d881183c6a2baa974/globalmount -o allow_other --file-cache-timeout-in-seconds=120 --use-attr-cache=true --cancel-list-on-mount-seconds=10 -o attr_timeout=120 -o entry_timeout=120 -o negative_timeout=120 --log-level=LOG_DEBUG --cache-size-mb=1000  --telemetry=azpartner-aks/v1.28.0,normaltest --pre-mount-validate=true --use-https=true --empty-dir-check=false --tmp-path=/mnt/<RG>#<Storage Account>#<Contianer>#<Blob>#default# --container-name=traineddata --ignore-open-flags=true --disable-version-check=true

Note: If there is no --telemetry in mount option then --telemetry=azpartner-aks/v1.28.0.

btw, I think just use --telemetry=aks/%s is more straightfoward

The tag has been suggested by @vibhansa-msft, so not sure if there is any monitoring from blobfuse side

}
mountOptions := mountFlags
if ephemeralVol {
mountOptions = util.JoinMountOptions(mountOptions, strings.Split(ephemeralVolMountOptions, ","))
Expand Down
Loading