-
Notifications
You must be signed in to change notification settings - Fork 306
chore: bump azclient to v0.14.3 and armcompute v6 -> v7 #9887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @tony-schndr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tony-schndr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
are we sure that this works on all clouds? |
|
@nilo19 As in Gov/China/Public right? I don't have those signals. We did test this in openshift ci for azurestack-ipi so I would think we can mark public cloud as OK? I am not sure how I would test this for the other clouds, what would you recommend? |
|
@tony-schndr we can't test it in sov clouds, but maybe we can ask sdk team to see if there is any blocking changes or unfinished rollout, etc. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump azclient to v0.14.3 and armcompute to v7 across all go.mod files in the repo. This change is required to support adding instant access snapshots for PremiumV2 and Ultra Disk types in the azuredisk-csi-driver. See kubernetes-sigs/azuredisk-csi-driver#3470
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: