Skip to content

Conversation

@tony-schndr
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump azclient to v0.14.3 and armcompute to v7 across all go.mod files in the repo. This change is required to support adding instant access snapshots for PremiumV2 and Ultra Disk types in the azuredisk-csi-driver. See kubernetes-sigs/azuredisk-csi-driver#3470

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2026
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 28, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @tony-schndr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tony-schndr
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2026
@nilo19
Copy link
Contributor

nilo19 commented Jan 29, 2026

are we sure that this works on all clouds?

@tony-schndr
Copy link
Contributor Author

@nilo19 As in Gov/China/Public right? I don't have those signals. We did test this in openshift ci for azurestack-ipi so I would think we can mark public cloud as OK? I am not sure how I would test this for the other clouds, what would you recommend?

See https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cloud-provider-azure/158/pull-ci-openshift-cloud-provider-azure-main-e2e-azurestack-ipi/2014714330628493312

@nilo19
Copy link
Contributor

nilo19 commented Jan 29, 2026

@tony-schndr we can't test it in sov clouds, but maybe we can ask sdk team to see if there is any blocking changes or unfinished rollout, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants