Skip to content

🐛 Try to upgrade Releases in pending states #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

🐛 Try to upgrade Releases in pending states #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/helm_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,11 @@ func shouldUpgradeHelmRelease(ctx context.Context, existing helmRelease.Release,
return true, nil
}

if existing.Info.Status == helmRelease.StatusPendingInstall || existing.Info.Status == helmRelease.StatusPendingUpgrade {
log.Info("Release is in a pending state, upgrading")
return true, nil
}
Copy link
Author

@nojnhuh nojnhuh Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jont828 Is there a place I could add a test for this? The closest place I could find with existing tests was in the HelmReleaseProxy controller tests where this is fronted by a mock, so this code wouldn't actually run.


klog.V(2).Infof("Diff between values is:\n%s", cmp.Diff(existing.Config, values))

// TODO: Comparing yaml is not ideal, but it's the best we can do since DeepEquals fails. This is because int64 types
Expand Down
Loading