-
Notifications
You must be signed in to change notification settings - Fork 47
🌱 Bump CAPI to v1.11.1 #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Welcome @changjjjjjjj! |
|
Hi @changjjjjjjj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
3d11f33 to
d55a0fe
Compare
|
Hi @jackfrancis @Jont828 @mboersma , this PR removes deprecated status clusterv1.conditions from the status field. As you can check from e2e test results, I think the changes do not affect controller behavior. I will appreciate if you give an opinion about ignoring apidiff test failure. |
|
@changjjjjjjj I'll let @mboersma do an audit of the v1beta2 changes, in the meantime you could rebase this PR to overcome that blocker |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: changjjjjjjj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: changjjjjjjj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6155cea to
bdf708d
Compare
|
Ty for the contribution! Looks like you need a rebase btw. I'll take a look as well but if tests pass I think we should be in good shape. |
| name: "${CLUSTER_NAME}-md-0" | ||
| apiGroup: infrastructure.cluster.x-k8s.io | ||
| kind: DockerMachineTemplate | ||
| failureDomain: fd4 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a newline at the end here? And same for the other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and added newlines as you mentioned. It would be grateful if you give opinions about apidiff test.
|
What do we need to do in order to get this merged? The author @changjjjjjjj appears to have abandoned this. |
|
@scrothers you could submit a PR of these changes yourself |
bdf708d to
cae4f42
Compare
cae4f42 to
c4580e3
Compare
c4580e3 to
e4d3ace
Compare
|
@changjjjjjjj: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Bumps the Cluster API dependency to release v1.11.1. Also bumps go version to fix CVEs
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #413