Skip to content

Conversation

@chaitanyakolluru
Copy link

What this PR does / why we need it:

This is a rework of an earlier merge request #443 to add an initial rollout size within HelmChartProxy.

This change adds in a new optional field called rollout, using which you can define an initial step size, optionally an increment size and a limit to how much the rollout step size can be increased to. These options can be defined individually for installs vs upgrade operations, allowing you to setup a different strategy for each kind of operation. Rollout quantities can be defined as an integer or a percentage of the total matched count of clusters. Below is an example showing the rollout option:

apiVersion: addons.cluster.x-k8s.io/v1alpha1
kind: HelmChartProxy
metadata:
  name: metallb
spec:
  rollout:
    install:
      stepInit: 10%
      stepIncrement: 5%
      stepLimit: 25%
    upgrade:
      stepInit: 10%
      stepIncrement: 5%
      stepLimit: 25%
  clusterSelector:
    matchLabels:
      MetalLBChart: enabled
  repoURL: https://metallb.github.io/metallb
  chartName: metallb
  releaseName: metallb

A new status condition HelmReleaseProxiesRolloutCompleted is added to denote rollout progress and is baked into the overall Ready condition set at the resource level.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chaitanyakolluru
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @chaitanyakolluru. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 3, 2025
@chaitanyakolluru chaitanyakolluru marked this pull request as draft November 5, 2025 15:13
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants