🐛 Allow non canonical image paths #928
Conversation
Signed-off-by: alexander-demicev <[email protected]>
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: alexander-demicev <[email protected]>
alexander-demicev
force-pushed
the
noncanonicalimages
branch
from
4072d75 to
3fb742f
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 32aad21174510748712b304a3073f3361a349dc0
|
|
/cherry-pick release-0.23 |
|
@alexander-demicev: new pull request created: #932 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@alexander-demicev: new pull request created: #933 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
What this PR does / why we need it:
We have a use-case where CAPI operator doesn't work in air-gapped environments because it doesn't allow non-canonical images references like
example/image:v0.0.1onlyexample.com/image:v0.0.1is allowed and this done on theclusterctllevel. This PR fixes the issue by skipping all image processing in case of non-canonical image assuming that this is for advanced users and they know what they are doing.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #