✨ feat: create vpc objects in explicitly provided availability zones #4950

synthe102 · 2024-04-23T16:16:59Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4333, continues the work started by @Skarlso in this PR by:

moving the defaults for AvailabilityZoneSelection and AvailabilityZoneUsageLimit into defaulting webhooks instead of CRDs
adding check in validating webhooks for conflicting use of AvailabilityZoneUsageLimit and AvailabilityZoneSelection with AvailabilityZones

Special notes for your reviewer:

Checklist:

Release note:

Ability to specify Availability Zones from spec.network.vpc in AWSManagedControlPlane, AWSCluster and AWSClusterTemplate CRDs.

k8s-ci-robot · 2024-04-23T16:17:08Z

Hi @synthe102. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AndiDog · 2024-07-03T10:51:07Z

/ok-to-test

AndiDog

Please change the release note to something that's readable by users (.spec.vpc) instead of developers (VPCSpec), and best use a verb to describe the change.

api/v1beta2/awscluster_webhook.go

api/v1beta2/network_types.go

controlplane/eks/api/v1beta2/awsmanagedcontrolplane_webhook.go

pkg/cloud/services/network/subnets.go

k8s-triage-robot · 2025-02-03T21:59:05Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

synthe102 · 2025-02-04T16:10:52Z

/remove-lifecycle stale

k8s-triage-robot · 2025-05-05T16:22:52Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

cpwc · 2025-05-05T16:30:42Z

/remove-lifecycle stale

cpwc · 2025-05-05T16:32:15Z

@AndiDog the PR has been rebased, hope we'll get a last review 🙏

synthe102 · 2025-06-13T07:17:07Z

/retest-required

AndiDog

Really sorry for the lengthy process – I was gone for a while and busy that last year. One more comment about the test. Otherwise this looks good.

@kubernetes-sigs/cluster-api-provider-aws-maintainers any thoughts about the changed defaulting, or other concerns? I'll LGTM this after the last comment is done.

pkg/cloud/services/network/subnets_test.go

AndiDog · 2025-07-17T07:02:48Z

/test pull-cluster-api-provider-aws-e2e

richardcase · 2025-07-29T13:18:26Z

@kubernetes-sigs/cluster-api-provider-aws-maintainers any thoughts about the changed defaulting, or other concerns? I'll LGTM this after the last comment is done.

If i am reading correctly the defaults stay the same, its just how the defaults are applied (i.e. kubebuilder annotations vs webhook).

AndiDog · 2025-07-30T06:21:58Z

/lgtm

@richardcase for approval, maybe?

k8s-ci-robot · 2025-07-30T06:22:04Z

LGTM label has been added.

Git tree hash: 4872976f065d1dc80013c1d3c3a943a38447804d

Ankitasw · 2025-09-01T08:08:48Z

/approve

k8s-ci-robot · 2025-09-01T08:08:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-09-01T08:08:58Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-09-03T11:29:30Z

@synthe102: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-build-release-2-6	`f0fbb06`	link	true	`/test pull-cluster-api-provider-aws-build-release-2-6`
pull-cluster-api-provider-aws-build-docker-release-2-6	`f0fbb06`	link	true	`/test pull-cluster-api-provider-aws-build-docker-release-2-6`
pull-cluster-api-provider-aws-build-docker	`6ed43e0`	link	unknown	`/test pull-cluster-api-provider-aws-build-docker`
pull-cluster-api-provider-aws-verify	`6ed43e0`	link	unknown	`/test pull-cluster-api-provider-aws-verify`
pull-cluster-api-provider-aws-e2e-blocking	`6ed43e0`	link	unknown	`/test pull-cluster-api-provider-aws-e2e-blocking`
pull-cluster-api-provider-aws-build	`6ed43e0`	link	unknown	`/test pull-cluster-api-provider-aws-build`
pull-cluster-api-provider-aws-test	`6ed43e0`	link	unknown	`/test pull-cluster-api-provider-aws-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

AndiDog · 2025-10-16T05:46:15Z

@synthe102 can you please rebase?

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 23, 2024

k8s-ci-robot requested review from AndiDog and faiq April 23, 2024 16:17

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2024

synthe102 force-pushed the main branch from 00e0e30 to fcea9eb Compare April 23, 2024 16:17

synthe102 mentioned this pull request Apr 23, 2024

✨ feat: create vpc objects in explicitly provided availability zones #4543

Closed

4 tasks

synthe102 force-pushed the main branch 2 times, most recently from 2f7fce6 to fab5efd Compare April 23, 2024 19:39

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2024

synthe102 force-pushed the main branch from fab5efd to 5f7baee Compare May 13, 2024 08:49

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024

synthe102 force-pushed the main branch from 5f7baee to 4526048 Compare May 27, 2024 15:41

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2024

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2024

AndiDog reviewed Jul 3, 2024

View reviewed changes

synthe102 force-pushed the main branch 7 times, most recently from ca10c55 to 41de7ec Compare July 17, 2024 10:00

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2025

AndiDog reviewed Jul 17, 2025

View reviewed changes

pkg/cloud/services/network/subnets_test.go Show resolved Hide resolved

synthe102 force-pushed the main branch 5 times, most recently from d9b6061 to 1663ae5 Compare July 28, 2025 19:04

feat: create vpc objects in explicitly provided availability zones

6ed43e0

synthe102 force-pushed the main branch from 1663ae5 to 6ed43e0 Compare July 28, 2025 21:13

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2025

✨ feat: create vpc objects in explicitly provided availability zones #4950

Are you sure you want to change the base?

✨ feat: create vpc objects in explicitly provided availability zones #4950

Conversation

synthe102 commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Apr 23, 2024

Uh oh!

AndiDog commented Jul 3, 2024

Uh oh!

AndiDog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k8s-triage-robot commented Feb 3, 2025

Uh oh!

synthe102 commented Feb 4, 2025

Uh oh!

k8s-triage-robot commented May 5, 2025

Uh oh!

cpwc commented May 5, 2025

Uh oh!

cpwc commented May 5, 2025

Uh oh!

synthe102 commented Jun 13, 2025

Uh oh!

AndiDog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AndiDog commented Jul 17, 2025

Uh oh!

richardcase commented Jul 29, 2025

Uh oh!

AndiDog commented Jul 30, 2025

Uh oh!

k8s-ci-robot commented Jul 30, 2025

Uh oh!

Ankitasw commented Sep 1, 2025

Uh oh!

k8s-ci-robot commented Sep 1, 2025

Uh oh!

k8s-ci-robot commented Sep 1, 2025

Uh oh!

k8s-ci-robot commented Sep 3, 2025

Uh oh!

AndiDog commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

synthe102 commented Apr 23, 2024 •

edited

Loading