Skip to content

🐛 ROSA: Fix autoRepair default value #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

🐛 ROSA: Fix autoRepair default value #4994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_rosamachinepools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ spec:
underlying EC2 instances associated with this machine pool.
type: object
autoRepair:
default: false
default: true
description: |-
AutoRepair specifies whether health checks should be enabled for machines
in the NodePool. The default is false.
in the NodePool. The default is true.
type: boolean
autoscaling:
description: |-
Expand Down
4 changes: 2 additions & 2 deletions exp/api/v1beta2/rosamachinepool_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ type RosaMachinePoolSpec struct {
AdditionalTags infrav1.Tags `json:"additionalTags,omitempty"`

// AutoRepair specifies whether health checks should be enabled for machines
// in the NodePool. The default is false.
// +kubebuilder:default=false
// in the NodePool. The default is true.
// +kubebuilder:default=true
// +optional
AutoRepair bool `json:"autoRepair,omitempty"`

Expand Down