Skip to content

🐛 fix(nodegroup): add nil pointer check for nodegroup version #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

🐛 fix(nodegroup): add nil pointer check for nodegroup version #5019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/cloud/services/eks/nodegroup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,11 @@ func (s *NodegroupService) reconcileNodegroupVersion(ng *eks.Nodegroup) error {
return fmt.Errorf("parsing EKS version from spec: %w", err)
}
}

// Check for nil pointers before dereferencing
if ng.Version == nil {
return fmt.Errorf("nodegroup version is nil")
}
Comment on lines +337 to +340
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the nodegroup status, just returning nil is not enough here

[capa-controller-manager-76cf9fbf-z76f8] 1 controller.go:316] "Reconciler error" err="failed to reconcile machine pool for AWSManagedMachinePool cluster-685bea824f4b2e09eb5c7654/gpu-worker--r5mh: failed to reconcile nodegroup version: nodegroup version is nil" controller="awsmanagedmachinepool" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSManagedMachinePool" AWSManagedMachinePool="cluster-685bea824f4b2e09eb5c7654/gpu-worker--r5mh" namespace="cluster-685bea824f4b2e09eb5c7654" name="gpu-worker--r5mh" reconcileID="f863c423-57f7-4bac-838e-82ffabf9e73a"

ngVersion := version.MustParseGeneric(*ng.Version)
specAMI := s.scope.ManagedMachinePool.Spec.AMIVersion
ngAMI := *ng.ReleaseVersion
Expand Down
Loading