Skip to content

🐛 fix: properly restart cloud-init #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

🐛 fix: properly restart cloud-init #5116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/cloud/services/secretsmanager/secret_fetch_script.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ if [ ${GUNZIP_RETURN} -ne 0 ]; then
fi

log::info "restarting cloud-init"
systemctl restart cloud-init
rm -rf /var/lib/cloud/instances
cloud-init clean --reboot
Comment on lines +234 to +235
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rm -rf /var/lib/cloud/instances
cloud-init clean --reboot
reboot

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried the following that worked without reboot:

rm -rf /var/lib/cloud/instances
cloud-init clean
systemctl restart cloud-init-local
systemctl restart cloud-init
systemctl restart cloud-config
systemctl restart cloud-final

log::success_exit
`
3 changes: 2 additions & 1 deletion pkg/cloud/services/ssm/secret_fetch_script.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ if [ ${GUNZIP_RETURN} -ne 0 ]; then
fi

log::info "restarting cloud-init"
systemctl restart cloud-init
rm -rf /var/lib/cloud/instances
cloud-init clean --reboot
Comment on lines +199 to +200
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rm -rf /var/lib/cloud/instances
cloud-init clean --reboot
reboot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im going to try again with some updates i made to failing tests #5118

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SriRamanujam the tests are all passing - mind building and trying again locally?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also hit this issue and we found out that reboot is not needed after cloud-init clean. We just needed to restart all cloud-init services in the order.

Suggested change
rm -rf /var/lib/cloud/instances
cloud-init clean --reboot
rm -rf /var/lib/cloud/instances
cloud-init clean
systemctl restart cloud-init-local
systemctl restart cloud-init
systemctl restart cloud-config
systemctl restart cloud-final

log::success_exit
`
Loading