-
Notifications
You must be signed in to change notification settings - Fork 635
🌱 Align cluster-template.yaml and cluster-template-flatcar.yaml
#5157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Align cluster-template.yaml and cluster-template-flatcar.yaml
#5157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
|
/assign @nrb @richardcase @dlipovetsky |
|
/cherrypick release-2.6 |
|
@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@richardcase: #5157 failed to apply on top of branch "release-2.6": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind support
What this PR does / why we need it:
This moves, quotes and formats YAML to make the diff between the two templates close to zero.
ClusterRole/ebs-csi-nodeand permissions forClusterRole/cloud-controller-managerare added.Checklist:
Release note: