Skip to content

Conversation

@richardcase
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This downgrades customize v5 to version 5.3.0 from 5.5.0 as there is an issue using the higher vsrion as it requires go version 1.22.7 and the gcloud build image only has a lower version of go.

make -C hack/tools bin/kustomize
make[4]: Entering directory '/workspace/hack/tools'
mkdir -p bin
CGO_ENABLED=0 go build -tags=tools -o bin/kustomize sigs.k8s.io/kustomize/kustomize/v5
go: go.mod requires go >= 1.22.7 (running go 1.22.0; GOTOOLCHAIN=local)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2024
@richardcase richardcase changed the title 🐛chore: downgrade kustomizt v5 version 🐛chore: downgrade kustomize v5 version Oct 28, 2024
This downgrades customize v5 to version 5.3.0 from 5.5.0 as there is
an issue using the higher vsrion as it requires go version 1.22.7 and
the gcloud build image only has a lower version of go.

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2024
Copy link
Contributor

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nrb
Copy link
Contributor

nrb commented Oct 28, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1416be7 into kubernetes-sigs:main Oct 28, 2024
20 checks passed
@richardcase
Copy link
Member Author

/cherrypick release-2.7

@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5190

In response to this:

/cherrypick release-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nrb added a commit to nrb/cluster-api-provider-aws that referenced this pull request Dec 6, 2024
Kustomize previously broke builds
(kubernetes-sigs#5188)
and we mistakenly approved a version bump
(kubernetes-sigs#5232)
that caused the Go version to be >= 1.22.7. As of right now, the builder
image only has Go 1.22.0.

This change downgrades the relevant kustomize dependencies, as well as
prevents dependabot from incrementing kustomize automatically in the
future.

Signed-off-by: Nolan Brubaker <[email protected]>
alam0rt pushed a commit to alam0rt/cluster-api-provider-aws that referenced this pull request Sep 4, 2025
Kustomize previously broke builds
(kubernetes-sigs#5188)
and we mistakenly approved a version bump
(kubernetes-sigs#5232)
that caused the Go version to be >= 1.22.7. As of right now, the builder
image only has Go 1.22.0.

This change downgrades the relevant kustomize dependencies, as well as
prevents dependabot from incrementing kustomize automatically in the
future.

Signed-off-by: Nolan Brubaker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants