Skip to content

Conversation

@serngawy
Copy link
Contributor

@serngawy serngawy commented Dec 3, 2024

What type of PR is this?
Add availableUpgrades for ROSAMachinePool.Status and update ROSA upgrade doc.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • [ X] squashed commits
  • [ X] includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Update ROSA upgrade documentation 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from AndiDog and nrb December 3, 2024 16:52
@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @serngawy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serngawy
Copy link
Contributor Author

serngawy commented Dec 4, 2024

@nrb @AndiDog would you add ok-to-test

@nrb
Copy link
Contributor

nrb commented Dec 5, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2024
@serngawy
Copy link
Contributor Author

serngawy commented Dec 9, 2024

Would you @nrb @AndiDog review & merge if there is no comments

@nrb
Copy link
Contributor

nrb commented Dec 10, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@serngawy
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-test

@nrb
Copy link
Contributor

nrb commented Dec 11, 2024

/test pull-cluster-api-provider-aws-test

Maximum number of VPCs reached

@k8s-ci-robot k8s-ci-robot merged commit 10234ff into kubernetes-sigs:main Dec 11, 2024
23 of 24 checks passed
@serngawy serngawy deleted the mpUpgrade branch October 6, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants