🌱 Migrate ServiceLimiters to AWS SDK V2

[punkwalker]

What type of PR is this?
/kind cleanup
/kind deprecation

What this PR does / why we need it:

It migrates ServiceLimiter implementation to comply with AWS SDK V2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Waiting for task to be created.

Special notes for your reviewer:
This will allow following clients to incorporate ServiceLimiters with AWS SDK V2.

		ec2.ServiceID:                      newEC2ServiceLimiter(),
		elb.ServiceID:                      newGenericServiceLimiter(),
		elbv2.ServiceID:                    newGenericServiceLimiter(),
		resourcegroupstaggingapi.ServiceID: newGenericServiceLimiter(),
		secretsmanager.ServiceID:           newGenericServiceLimiter(),

Usage:

<service>.WithAPIOptions(
			awsmetricsv2.WithMiddlewares(scopeUser.ControllerName(), target),
			awsmetricsv2.WithCAPAUserAgentMiddleware(),
			throttle.WithServiceLimiterMiddleware(session.ServiceLimiter(<service>.ServiceID)),
		)

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

 Migrate ServiceLimiters to AWS SDK V2

[k8s-ci-robot]

Hi @punkwalker. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

/ok-to-test

[damdo]

@punkwalker There's some small linting issue to fix

[punkwalker]

@punkwalker There's some small linting issue to fix

Yes. Will fix in a bit. 🙂

[damdo]

/assign @nrb @richardcase

[damdo]

I am not an expert on these but they look reasonable to me

/lgtm

/assign @nrb @richardcase @AndiDog @dlipovetsky

For approval

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1d2e5c91a325c36d703cedaad65dc2f286febb35

[nrb]

Awesome, thanks for this. It wasn't obvious to me from the docs on how to incorporate this behavior.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[phuhung273]

GOMAXPROCS=2 can help unblock release-binaries, but I dont know why 😅

[damdo]

/retest pull-cluster-api-provider-aws-build-docker

[k8s-ci-robot]

@damdo: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-e2e-blocking

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/retest pull-cluster-api-provider-aws-build-docker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

/test pull-cluster-api-provider-aws-build-docker

[damdo]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 0caed964f67185bbc50188fa66d45ddf02b2bef6

[damdo]

/label tide/merge-method-squash

[mdbooth]

Setting the goreleaser parallelism to 2 reduced maximum memory consumption of the build-docker job to 4.28G without impacting the runtime of 26m. I think this is a solid change. I'd recommend adding a comment about why the value is there, though, or we'll forget. See #5576 and #5577.