-
Notifications
You must be signed in to change notification settings - Fork 635
✨ IPv6 support for self-managed clusters #5603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
7949ccb
c1bafb0
842f85a
60308b2
7826e7e
987bc9c
7bbae60
cd6c178
1ebffda
2c7e1e4
da96854
cd7c9b2
def75f2
9851222
ea41d67
bfbbb84
4d38ed3
e5e3ad3
04d4286
b8ca23a
3292f75
78cb9d4
061134a
4701b61
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -321,6 +321,13 @@ func (s *Service) getNatGatewayPrivateRoute(natGatewayID string) *ec2.CreateRout | |||||||||||||
} | ||||||||||||||
} | ||||||||||||||
|
||||||||||||||
func (s *Service) getNat64PrivateRoute(natGatewayID string) *ec2.CreateRouteInput { | ||||||||||||||
return &ec2.CreateRouteInput{ | ||||||||||||||
NatGatewayId: aws.String(natGatewayID), | ||||||||||||||
DestinationIpv6CidrBlock: aws.String(services.NAT64CidrBlock), | ||||||||||||||
} | ||||||||||||||
} | ||||||||||||||
|
||||||||||||||
func (s *Service) getEgressOnlyInternetGateway() *ec2.CreateRouteInput { | ||||||||||||||
return &ec2.CreateRouteInput{ | ||||||||||||||
DestinationIpv6CidrBlock: aws.String(services.AnyIPv6CidrBlock), | ||||||||||||||
|
@@ -415,6 +422,7 @@ func (s *Service) getRoutesToPrivateSubnet(sn *infrav1.SubnetSpec) (routes []*ec | |||||||||||||
|
||||||||||||||
routes = append(routes, s.getNatGatewayPrivateRoute(natGatewayID)) | ||||||||||||||
if sn.IsIPv6 { | ||||||||||||||
routes = append(routes, s.getNat64PrivateRoute(natGatewayID)) | ||||||||||||||
|
func (s *Service) getRoutesForSubnet(sn *infrav1.SubnetSpec) ([]*ec2.CreateRouteInput, error) { | |
if sn.IsPublic { | |
return s.getRoutesToPublicSubnet(sn) | |
} | |
return s.getRoutesToPrivateSubnet(sn) | |
} |
The func getRoutesToPrivateSubnet
is only ever used for getting routes for private subnets :D
Not sure why this was not needed for managed installs
This route is actually a component of DNS64 (NAT64 is always on) to resolve an IPv4-only internet service to a synthetic IPv6 (See here). It is really a nice-to-have feature 🤔 but not required.
My guess was that when Ipv6 was supported for managed eks, they didn't need IPv6-only pods to access IPv4-only internet services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I think CAPA currently support IPv6 for EKS by using dualstack subnets. And NAT64/DNS64 is really meant for IPv6-only subnets, not dualstack subnets (unless really necessary).
See details in commit: 78cb9d4
Uh oh!
There was an error while loading. Please reload this page.