-
Notifications
You must be signed in to change notification settings - Fork 634
✨ IPv6 support for self-managed clusters #5603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
7949ccb
c1bafb0
842f85a
60308b2
7826e7e
987bc9c
7bbae60
cd6c178
1ebffda
2c7e1e4
da96854
cd7c9b2
def75f2
9851222
ea41d67
bfbbb84
4d38ed3
e5e3ad3
04d4286
b8ca23a
3292f75
78cb9d4
061134a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -365,6 +365,15 @@ type InstanceMetadataOptions struct { | |
// +kubebuilder:default=enabled | ||
HTTPEndpoint InstanceMetadataState `json:"httpEndpoint,omitempty"` | ||
|
||
// Enables or disables the IPv6 endpoint for the instance metadata service. | ||
// This applies only if you enabled the HTTP metadata endpoint. | ||
// | ||
// Default: disabled | ||
// | ||
// +kubebuilder:validation:Enum:=enabled;disabled | ||
// +kubebuilder:default=disabled | ||
HTTPProtocolIPv6 InstanceMetadataState `json:"httpProtocolIpv6,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Should this be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahh, the name $ aws ec2 modify-instance-metadata-options --instance-id i-1234567890 \
--http-endpoint=disabled --http-protocol-ipv6=enabled
{
"InstanceId": "i-1234567890",
"InstanceMetadataOptions": {
"State": "pending",
"HttpTokens": "required",
"HttpPutResponseHopLimit": 2,
"HttpEndpoint": "disabled",
"HttpProtocolIpv6": "enabled",
"InstanceMetadataTags": "disabled"
}
} https://docs.aws.amazon.com/cli/latest/reference/ec2/modify-instance-metadata-options.html There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that's the convention here in capa 👀 so we should keep it this way? |
||
|
||
// The desired HTTP PUT response hop limit for instance metadata requests. The | ||
// larger the number, the further instance metadata requests can travel. | ||
// | ||
|
@@ -411,6 +420,9 @@ func (obj *InstanceMetadataOptions) SetDefaults() { | |
if obj.HTTPEndpoint == "" { | ||
obj.HTTPEndpoint = InstanceMetadataEndpointStateEnabled | ||
} | ||
if obj.HTTPProtocolIPv6 == "" { | ||
obj.HTTPProtocolIPv6 = InstanceMetadataEndpointStateDisabled | ||
} | ||
if obj.HTTPPutResponseHopLimit == 0 { | ||
obj.HTTPPutResponseHopLimit = 1 | ||
} | ||
|
Uh oh!
There was an error while loading. Please reload this page.