-
Notifications
You must be signed in to change notification settings - Fork 623
✨ Capacity reservation preferences #5609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Capacity reservation preferences #5609
Conversation
Welcome @BraeTroutman! |
Hi @BraeTroutman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d83d106
to
592e975
Compare
59689b7
to
0ec1390
Compare
0ec1390
to
6e15f9b
Compare
/kind feature |
/ok-to-test |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Linter errors fixed locally: I'll leave the follow up commits here for tracking for now, and re-squash once we're satisfied with the state of things |
update all the API types that map to EC2 RunInstance operations, allowing for the specification of CapacityReservationPreference as well as validations to ensure that these values play well with AWS specifications for use of CapacityReservationPreference with CapacityReservationID
036186d
to
aa0e221
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for the running of EC2 instances with capacity reservation preferences: that is, allowing an instance to be run to:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5606
Special notes for your reviewer:
Checklist:
Release note: