Skip to content

🌱 e2e: create tarball as artifact with pod logs for debugging #5622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

🌱 e2e: create tarball as artifact with pod logs for debugging #5622

merged 1 commit into from
Aug 20, 2025

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Aug 19, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Allows e2e tests to dump pod logs to further analyze issues which e.g. require to take a look at kube-apiserver logs like mentioned here: https://kubernetes.slack.com/archives/C8TSNPY4T/p1755619040487799

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Aug 19, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Aug 19, 2025

/test help

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 19, 2025

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-e2e-blocking

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

chrischdi commented Aug 19, 2025

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@chrischdi
Copy link
Member Author

chrischdi commented Aug 19, 2025

/assign nrb

@chrischdi
Copy link
Member Author

chrischdi commented Aug 19, 2025

/retest

unrelated error

@nrb
Copy link
Contributor

nrb commented Aug 19, 2025

Timed out trying to get an account from boskos.

/retest

@chrischdi
Copy link
Member Author

chrischdi commented Aug 19, 2025

/hold

Does Not Work yet

tar: Refusing to write archive contents to terminal (missing -f option?)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Aug 20, 2025

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

1 similar comment
@chrischdi
Copy link
Member Author

chrischdi commented Aug 20, 2025

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@richardcase
Copy link
Member

richardcase commented Aug 20, 2025

Thats a simpler solution than i was thinking of (using ctr/xargs/...), thanks @chrischdi

@chrischdi
Copy link
Member Author

chrischdi commented Aug 20, 2025

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 20, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Aug 20, 2025

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 20, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Aug 20, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Aug 20, 2025

/hold

Have to figure out what I did do wrong :D

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Aug 20, 2025

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 20, 2025

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts 7f1e276 link false /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member Author

chrischdi commented Aug 20, 2025

Works as expected, pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts is expected to fail because we still set --cloud-provider=external (and the flag does not exist anymore).

Example: https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5622/pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts/1958156613369991168/artifacts/clusters/bootstrap/instances/conformance-gxo87r/conformance-tmv9l4-control-plane-txlz7/pod-logs.tar

/hold cancel
/overwrite pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@nrb
Copy link
Contributor

nrb commented Aug 20, 2025

/lgtm
/approve

Thanks! This will be super helpful for debugging!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 20, 2025

LGTM label has been added.

Git tree hash: 766966ec7141e185c62b0ed427013460e0704d81

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 645f38e into kubernetes-sigs:main Aug 20, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

Assignees

@nrb nrb

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrischdi @k8s-ci-robot @nrb @richardcase