🌱 Upgrade Go version to 1.24 #5652
Merged
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/support
k8s-ci-robot
added
the
size/S
bryan-cox
changed the title
bryan-cox
changed the title
k8s-ci-robot
added
release-note
|
/test pull-cluster-api-provider-aws-test |
damdo
reviewed
Sep 5, 2025
go.mod
Outdated
| module sigs.k8s.io/cluster-api-provider-aws/v2 | ||
|
|
||
| go 1.23.1 | ||
| go 1.24.7 |
There was a problem hiding this comment.
With this we need to stay to go 1.24.0, so always to the 0 patch release to avoid importing issues from other components
damdo
reviewed
Sep 5, 2025
hack/tools/go.mod
Outdated
| module sigs.k8s.io/cluster-api-provider-aws/hack/tools | ||
|
|
||
| go 1.24.0 | ||
| go 1.24.7 |
There was a problem hiding this comment.
|
Given the changes I suggested I would call this PR and the release notes |
For these you can use |
damdo
reviewed
Sep 5, 2025
|
|
||
| # Go | ||
| GO_VERSION ?=1.23.9 | ||
| GO_VERSION ?=1.24.7 |
- Update go.mod and hack/tools/go.mod to Go 1.24.7 - Update Makefile GO_VERSION to 1.24.7 - Update GitHub Actions workflow to use Go 1.24 - Update golangci-kal.yml to use Go 1.24 - Upgrade golangci-lint to v1.60.3 for Go 1.24 compatibility
bryan-cox
force-pushed
the
bump-golang
branch
from
057b1ed to
bf170ad
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 28ee518f5975a6afbab9eff3dff946bffd07a153
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind support
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: