🐛 Fix deprecated deprecated image check

[mzazrivec]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes pipeline failures:

✕ [Violation] tasks.required_untrusted_task_found
  ImageRef: quay.io/redhat-user-workloads/crt-redhat-acm-tenant/cluster-api-provider-aws-mce-210@sha256:dfa6ece0d3c74305bbaba741cc9f9b96a4a46ef0aa12bf85e200b5ceffa104b4
  Reason: Required task "deprecated-image-check" is required and present but not from a trusted task
  Term: deprecated-image-check
  Title: All required tasks are from trusted tasks
  Description: Ensure that the all required tasks are resolved from trusted tasks. To exclude this rule add
  "tasks.required_untrusted_task_found:deprecated-image-check" to the `exclude` section of the policy configuration.
  Solution: Make sure all required tasks in the build pipeline are resolved from trusted tasks.

✕ [Violation] trusted_task.trusted
  ImageRef: quay.io/redhat-user-workloads/crt-redhat-acm-tenant/cluster-api-provider-aws-mce-210@sha256:dfa6ece0d3c74305bbaba741cc9f9b96a4a46ef0aa12bf85e200b5ceffa104b4
  Reason: Untrusted version of PipelineTask "deprecated-base-image-check" (Task "deprecated-image-check") was included in build
  chain comprised of: deprecated-base-image-check. Please upgrade the task version to:
  sha256:f59175d9a0a60411738228dfe568af4684af4aa5e7e05c832927cb917801d489
  Term: deprecated-image-check
  Title: Tasks are trusted
  Description: Check the trust of the Tekton Tasks used in the build Pipeline. There are two modes in which trust is verified. The
  first mode is used if Trusted Artifacts are enabled. In this case, a chain of trust is established for all the Tasks involved in
  creating an artifact. If the chain contains an untrusted Task, then a violation is emitted. The second mode is used as a
  fallback when Trusted Artifacts are not enabled. In this case, **all** Tasks in the build Pipeline must be trusted. To exclude
  this rule add "trusted_task.trusted:deprecated-image-check" to the `exclude` section of the policy configuration.
  Solution: If using Trusted Artifacts, be sure every Task in the build Pipeline responsible for producing a Trusted Artifact is
  trusted. Otherwise, ensure **all** Tasks in the build Pipeline are trusted. Note that trust is eventually revoked from Tasks
  when newer versions are made available.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[linux-foundation-easycla]

• ✅ login: serngawy / name: Mohamed ElSerngawy (3e8dcdc, 6543001, 8873cd2, 07aab8e, 348ff43, 086f864, 42618e4, cda5975, 44fd6c7, 5f2f27e, 22b2663, 72660d8)
• ✅ login: damdo / name: Damiano Donati (b6abdf9)
• ✅ login: joshfrench / name: Josh French (ba4cf4e)
• ✅ login: dependabot[bot] / name: dependabot[bot] (006ee66, 156a354, aacff7b, 16edbf3)
• ✅ login: mzazrivec / name: Milan Zázrivec (2e9a0f5, b69e87a, f58126e, 877628a, 2216e81, 91b2ee9, a9414a3, 86ecf29, 91a530c)
• ✅ login: andreadecorte / name: Andrea Decorte (338ea1f)
• ✅ login: tthvo / name: Thuan Vo (4e29f52)
• ✅ login: fangge1212 / name: Fangge Jin (5d8db8c)
• ✅ login: alexander-demicev / name: Alexander Demicev (8bc8aec)
• ❌ The email address for the commit (7b25ddd) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ankitasw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @mzazrivec. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes-sigs org. You can then trigger verification by writing /verify-owners in a comment.

• marek-veber
  • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
• mzazrivec
  • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
• capi-admins
  • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • OWNERS