Skip to content

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5649

/assign serngawy

New ROSAMachinePool parameter for specifying AWS capacity reservation.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Oct 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from faiq and serngawy October 7, 2025 17:02
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 7, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @nrb @richardcase

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 10c3a64be2bed4bcb3f734f20cc359e4a3221f9a

@damdo
Copy link
Member

damdo commented Oct 7, 2025

@serngawy the verify job is failing, do we need to regenerate?

@serngawy
Copy link
Contributor

serngawy commented Oct 7, 2025

@serngawy the verify job is failing, do we need to regenerate?

it complain about verify-book-link, the PR doesn't have docs AND it didn't fail locally

@serngawy
Copy link
Contributor

serngawy commented Oct 7, 2025

/test pull-cluster-api-provider-aws-verify-release-2-9

@nrb
Copy link
Contributor

nrb commented Oct 7, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit c5aff43 into kubernetes-sigs:release-2.9 Oct 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants