Skip to content

[release-2.9] ✨ ROSANetwork: new CRD & reconciler to provision network infrastructure for ROSA-HCP #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[release-2.9] ✨ ROSANetwork: new CRD & reconciler to provision network infrastructure for ROSA-HCP #5701

wants to merge 2 commits into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5464

/assign serngawy

New API for provisioning network infrastructure for ROSA clusters

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 7, 2025
Merged
5 tasks
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from damdo and serngawy October 7, 2025 20:42
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 7, 2025
@damdo
Copy link
Member

damdo commented Oct 7, 2025

/retest

damdo
damdo reviewed Oct 7, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c5ea1accc9124285303dc94a4f8ef88d0573478a

@damdo
Copy link
Member

damdo commented Oct 7, 2025

/assign @nrb

@damdo
Copy link
Member

damdo commented Oct 8, 2025

/retest

1 similar comment
@damdo
Copy link
Member

damdo commented Oct 8, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-verify-release-2-9 47a52ea link true /test pull-cluster-api-provider-aws-verify-release-2-9

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serngawy
Copy link
Contributor

serngawy commented Oct 8, 2025

/close

@k8s-ci-robot
Copy link
Contributor

@serngawy: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serngawy
Copy link
Contributor

serngawy commented Oct 8, 2025

close this one for favor of this pr #5702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@serngawy serngawy Awaiting requested review from serngawy

Assignees

@nrb nrb

@serngawy serngawy

@damdo damdo

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@k8s-infra-cherrypick-robot @k8s-ci-robot @damdo @serngawy @nrb @mzazrivec