-
Notifications
You must be signed in to change notification settings - Fork 635
🌱 Bump CAPI to v1.11 and k8s to v1.33 #5720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clebs
wants to merge
6
commits into
kubernetes-sigs:main
Choose a base branch
from
clebs:bump-capi-k8s-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,109
−1,823
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
51b873e
deps: upgrade Kubernetes dependencies to v0.33.4
bryan-cox 45f0451
deps: update cluster-api to v1.11.1 and controller-runtime to v0.21.0
bryan-cox bfa570e
WIP no IDE errors
bryan-cox 619e66a
WIP IDE Errors
bryan-cox 9bc1f1f
Fix go dependencies
clebs d03484c
Update imports, code and generations to CAPI 1.11
clebs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,8 @@ package v1beta1 | |
| import ( | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1" | ||
| clusterv1beta1 "sigs.k8s.io/cluster-api/api/core/v1beta1" | ||
| clusterv1 "sigs.k8s.io/cluster-api/api/core/v1beta2" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I'm right then this package should not import It should use keep using Otherwise this could be considered a breaking api change (same for the whole package) |
||
| ) | ||
|
|
||
| const ( | ||
|
|
@@ -200,11 +201,11 @@ type AWSLoadBalancerSpec struct { | |
| // AWSClusterStatus defines the observed state of AWSCluster. | ||
| type AWSClusterStatus struct { | ||
| // +kubebuilder:default=false | ||
| Ready bool `json:"ready"` | ||
| Network NetworkStatus `json:"networkStatus,omitempty"` | ||
| FailureDomains clusterv1.FailureDomains `json:"failureDomains,omitempty"` | ||
| Bastion *Instance `json:"bastion,omitempty"` | ||
| Conditions clusterv1.Conditions `json:"conditions,omitempty"` | ||
| Ready bool `json:"ready"` | ||
| Network NetworkStatus `json:"networkStatus,omitempty"` | ||
| FailureDomains clusterv1beta1.FailureDomains `json:"failureDomains,omitempty"` | ||
| Bastion *Instance `json:"bastion,omitempty"` | ||
| Conditions clusterv1beta1.Conditions `json:"conditions,omitempty"` | ||
| } | ||
|
|
||
| // S3Bucket defines a supporting S3 bucket for the cluster, currently can be optionally used for Ignition. | ||
|
|
@@ -254,12 +255,12 @@ type AWSClusterList struct { | |
| } | ||
|
|
||
| // GetConditions returns the observations of the operational state of the AWSCluster resource. | ||
| func (r *AWSCluster) GetConditions() clusterv1.Conditions { | ||
| func (r *AWSCluster) GetConditions() clusterv1beta1.Conditions { | ||
| return r.Status.Conditions | ||
| } | ||
|
|
||
| // SetConditions sets the underlying service state of the AWSCluster to the predescribed clusterv1.Conditions. | ||
| func (r *AWSCluster) SetConditions(conditions clusterv1.Conditions) { | ||
| // SetConditions sets the underlying service state of the AWSCluster to the predescribed clusterv1beta1.Conditions. | ||
| func (r *AWSCluster) SetConditions(conditions clusterv1beta1.Conditions) { | ||
| r.Status.Conditions = conditions | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make lint-fix(orgolangci-lint run --fix)