-
Notifications
You must be signed in to change notification settings - Fork 460
ASOAPI: delete resources removed from spec #4810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/milestone v1.15 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4810 +/- ##
==========================================
+ Coverage 62.77% 62.81% +0.03%
==========================================
Files 199 199
Lines 16569 16588 +19
==========================================
+ Hits 10402 10420 +18
Misses 5389 5389
- Partials 778 779 +1 ☔ View full report in Codecov by Sentry. |
jackfrancis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 350ea60d241caca354b6f347b498dbd9ce04fce3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the logic for ASOAPI resources to delete resources that are removed from
spec.resourcesthrough an update like we did for the existing CAPZ APIs in #4506.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #4713
Special notes for your reviewer:
TODOs:
Release note: