-
Notifications
You must be signed in to change notification settings - Fork 460
Revert "use az to download storage blobs for custom builds" #4812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/label release-note-none |
|
@jackfrancis: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/release-note-none |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4812 +/- ##
=======================================
Coverage 62.77% 62.77%
=======================================
Files 199 199
Lines 16569 16569
=======================================
Hits 10402 10402
Misses 5389 5389
Partials 778 778 ☔ View full report in Codecov by Sentry. |
mboersma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: e846eb5cce667060d3c1db69aa41fe18306ae32a
|
nojnhuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jackfrancis Do we need to cherry-pick this? |
|
@nojnhuh need to get this back into 1.13 and 1.14 branches, yes doing some more local testing to validate the reversions works as expected, stay tuned... |
|
/cherry-pick release-1.13 |
|
@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #4813 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #4814 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Reverts #4724
Confirmed that this change doesn't work w/ the existing CI config. We'll have to introduce this change w/ this:
#4765