Skip to content

Conversation

@k8s-infra-cherrypick-robot

This is an automated cherry-pick of #4833

/assign willie-yao

Set cluster name label for pre-existing kubeconfig

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 14, 2024
@k8s-ci-robot k8s-ci-robot requested review from marosset and nojnhuh May 14, 2024 20:03
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 14, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented May 14, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d46d1ecc62b866033454078c91215709dba330d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@codecov
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.65%. Comparing base (7c032dd) to head (3c1bb0a).
Report is 3 commits behind head on release-1.14.

Files Patch % Lines
controllers/azuremanagedcontrolplane_reconciler.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #4846      +/-   ##
================================================
- Coverage         62.65%   62.65%   -0.01%     
================================================
  Files               192      192              
  Lines             15690    15694       +4     
================================================
+ Hits               9831     9833       +2     
- Misses             5172     5174       +2     
  Partials            687      687              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit fd6e294 into kubernetes-sigs:release-1.14 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants