Skip to content

Conversation

@mboersma
Copy link
Contributor

@mboersma mboersma commented May 22, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAAPH in tests to the current release v0.2.5.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2024
@mboersma
Copy link
Contributor Author

/assign @Jont828

@codecov
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.17%. Comparing base (cc3e8e9) to head (9051bd6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4869   +/-   ##
=======================================
  Coverage   51.17%   51.17%           
=======================================
  Files         273      273           
  Lines       24616    24616           
=======================================
  Hits        12597    12597           
  Misses      11234    11234           
  Partials      785      785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
@mboersma
Copy link
Contributor Author

/retitle Bump CAAPH to v0.2.3

@k8s-ci-robot k8s-ci-robot changed the title Bump CAAPH to v0.2.2 Bump CAAPH to v0.2.3 May 30, 2024
@mboersma
Copy link
Contributor Author

mboersma commented Jun 7, 2024

@Jont828 any idea what I'm doing wrong here?

 [FAILED] in [SynchronizedBeforeSuite] - /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.7.2/framework/clusterctl/client.go:90 @ 05/30/24 15:23:15.423
  << Timeline
  [FAILED] failed to run clusterctl init
  Unexpected error:
      <*errors.withStack | 0xc005509d58>: 
      failed to get provider components for the "helm" provider: failed to get repository client for the AddonProvider with name helm: error creating the local filesystem repository client: failed to get latest version: failed to find releases tagged with a valid semantic version number
      {
          error: <*errors.withMessage | 0xc0034798a0>{
              cause: <*errors.withStack | 0xc005509d28>{
                  error: <*errors.withMessage | 0xc003479880>{
                      cause: <*errors.withStack | 0xc005509cf8>{
                          error: <*errors.withMessage | 0xc003479860>{
                              cause: <*errors.withStack | 0xc005509cc8>{
                                  error: <*errors.withMessage | 0xc003479840>{
                                      cause: <*errors.fundamental | 0xc005509c98>{
                                          msg: "failed to find releases tagged with a valid semantic version number",
                                          stack: [..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ...],
                                      },
                                      msg: "failed to get latest version",
                                  },
                                  stack: [0x33b1e10, 0x33a6fca, 0x33a6bdd, 0x33a69dc, 0x378b430, 0x378c5ba, 0x3791a25, 0x37915a5, 0x37907e5, 0x38c4de8, 0x38ca568, 0x42049db, 0x4203052, 0x1a047c7, 0x1a03899, 0x2f4b3fc, 0x2f5be0e, 0x2f5f70d, 0x198b6c1],
                              },
                              msg: "error creating the local filesystem repository client",
                          },
                          stack: [0x33a6fe6, 0x33a6bdd, 0x33a69dc, 0x378b430, 0x378c5ba, 0x3791a25, 0x37915a5, 0x37907e5, 0x38c4de8, 0x38ca568, 0x42049db, 0x4203052, 0x1a047c7, 0x1a03899, 0x2f4b3fc, 0x2f5be0e, 0x2f5f70d, 0x198b6c1],
                      },
                      msg: "failed to get repository client for the AddonProvider with name helm",
                  },
                  stack: [0x33a6cdd, 0x33a69dc, 0x378b430, 0x378c5ba, 0x3791a25, 0x37915a5, 0x37907e5, 0x38c4de8, 0x38ca568, 0x42049db, 0x4203052, 0x1a047c7, 0x1a03899, 0x2f4b3fc, 0x2f5be0e, 0x2f5f70d, 0x198b6c1],
              },
              msg: "failed to get provider components for the \"helm\" provider",
          },
          stack: [0x3791e3a, 0x37915a5, 0x37907e5, 0x38c4de8, 0x38ca568, 0x42049db, 0x4203052, 0x1a047c7, 0x1a03899, 0x2f4b3fc, 0x2f5be0e, 0x2f5f70d, 0x198b6c1],
      }
  occurred
  In [SynchronizedBeforeSuite] at: /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.7.2/framework/clusterctl/client.go:90 @ 05/30/24 15:23:15.423
  Full Stack Trace

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2024
@mboersma
Copy link
Contributor Author

/retitle Bump CAAPH to v0.2.4

@k8s-ci-robot k8s-ci-robot changed the title Bump CAAPH to v0.2.3 Bump CAAPH to v0.2.4 Jun 12, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2024
@mboersma
Copy link
Contributor Author

mboersma commented Jul 8, 2024

/retest

@mboersma mboersma modified the milestones: v1.16, next Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@mboersma
Copy link
Contributor Author

/close

I'm still not sure what's wrong here, and there seems to be little interest, so I'll close it.

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

I'm still not sure what's wrong here, and there seems to be little interest, so I'll close it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

@mboersma: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma
Copy link
Contributor Author

/retitle Bump CAAPH to v0.2.5

@k8s-ci-robot k8s-ci-robot changed the title Bump CAAPH to v0.2.4 Bump CAAPH to v0.2.5 Aug 29, 2024
@mboersma mboersma removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 29, 2024

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-with-wi-optional e0a1d26 link false /test pull-cluster-api-provider-azure-e2e-with-wi-optional

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Jont828
Copy link
Contributor

Jont828 commented Aug 29, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d22f8526df7a75213ed22620d3ae9a3c03ccc0b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 698c657 into kubernetes-sigs:main Aug 29, 2024
@k8s-ci-robot k8s-ci-robot modified the milestones: next, v1.17 Aug 29, 2024
@mboersma mboersma deleted the bump-caaph branch August 30, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants