Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 26, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR wires up the ASO API controllers to the *-concurrency command line flags like the other controllers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 26, 2024
@codecov
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 51.17%. Comparing base (c4a3065) to head (6b2e3ec).
Report is 11 commits behind head on main.

Files Patch % Lines
main.go 0.00% 5 Missing ⚠️
controllers/agentpooladopt_controller.go 0.00% 2 Missing ⚠️
controllers/azureasomanagedcluster_controller.go 0.00% 2 Missing ⚠️
...trollers/azureasomanagedcontrolplane_controller.go 0.00% 2 Missing ⚠️
...ntrollers/azureasomanagedmachinepool_controller.go 0.00% 2 Missing ⚠️
controllers/managedclusteradopt_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5089      +/-   ##
==========================================
- Coverage   51.18%   51.17%   -0.02%     
==========================================
  Files         273      273              
  Lines       24611    24616       +5     
==========================================
  Hits        12597    12597              
- Misses      11229    11234       +5     
  Partials      785      785              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ce8b6964e16ef6e44c752ec49ca9bd1e37dbd57

@jackfrancis
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 07088c2 into kubernetes-sigs:main Aug 27, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Aug 27, 2024
@nojnhuh nojnhuh deleted the aso-concurrency branch September 20, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants