-
Notifications
You must be signed in to change notification settings - Fork 460
honor *-concurrency flags for ASO API controllers #5089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5089 +/- ##
==========================================
- Coverage 51.18% 51.17% -0.02%
==========================================
Files 273 273
Lines 24611 24616 +5
==========================================
Hits 12597 12597
- Misses 11229 11234 +5
Partials 785 785 ☔ View full report in Codecov by Sentry. |
mboersma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: 6ce8b6964e16ef6e44c752ec49ca9bd1e37dbd57
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR wires up the ASO API controllers to the
*-concurrencycommand line flags like the other controllers.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: