-
Notifications
You must be signed in to change notification settings - Fork 460
explicitly set EXP_ASO_API=true for controller-manager #5093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicitly set EXP_ASO_API=true for controller-manager #5093
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5093 +/- ##
=======================================
Coverage 51.18% 51.18%
=======================================
Files 273 273
Lines 24611 24611
=======================================
Hits 12597 12597
Misses 11229 11229
Partials 785 785 ☔ View full report in Codecov by Sentry. |
|
/retitle explicitly set EXP_ASO_API=true for controller-manager /cherry-pick release-1.16 |
|
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you for pointing this out @dtzar! |
|
/kind bug |
jackfrancis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 5df31d60c3134a2d57241e8247e3e3d842f8e701
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nojnhuh: new pull request created: #5095 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR updates the capz-controller-manager manifest to enable the ASOAPI feature flag by default to align with the intent of #4969: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4969/files#diff-bd8758c39c0deb35ee6c5c387594f6575580918777fbf2926f5762c7c9fce755R68
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: