Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 26, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

This PR updates the capz-controller-manager manifest to enable the ASOAPI feature flag by default to align with the intent of #4969: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4969/files#diff-bd8758c39c0deb35ee6c5c387594f6575580918777fbf2926f5762c7c9fce755R68

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Fixed a bug preventing the ASOAPI feature flag from being enabled by default.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2024
@codecov
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.18%. Comparing base (12d15fa) to head (2783c33).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5093   +/-   ##
=======================================
  Coverage   51.18%   51.18%           
=======================================
  Files         273      273           
  Lines       24611    24611           
=======================================
  Hits        12597    12597           
  Misses      11229    11229           
  Partials      785      785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 26, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 26, 2024

/retitle explicitly set EXP_ASO_API=true for controller-manager

/cherry-pick release-1.16
^ This is usually not something we'd cherry-pick, but the release note for #4969 says the flag is enabled by default while it currently is not for a plain clusterctl init. This PR should rectify that.

@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/retitle explicitly set EXP_ASO_API=true for controller-manager

/cherry-pick release-1.16
^ This is usually not something we'd cherry-pick, but the release note for #4969 says the flag is enabled by default while it currently is not for a plain clusterctl init. This PR should rectify that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot changed the title [WIP] testing implicit default for ASOAPI feature flag explicitly set EXP_ASO_API=true for controller-manager Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 26, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 26, 2024

Thank you for pointing this out @dtzar!

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 26, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 26, 2024
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5df31d60c3134a2d57241e8247e3e3d842f8e701

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6539f27 into kubernetes-sigs:main Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Aug 26, 2024
@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #5095

In response to this:

/retitle explicitly set EXP_ASO_API=true for controller-manager

/cherry-pick release-1.16
^ This is usually not something we'd cherry-pick, but the release note for #4969 says the flag is enabled by default while it currently is not for a plain clusterctl init. This PR should rectify that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh nojnhuh deleted the asoapi-flag-default branch September 20, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants