-
Notifications
You must be signed in to change notification settings - Fork 460
Add test templates for DRA-enabled clusters #5121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @jackfrancis |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5121 +/- ##
=======================================
Coverage 51.25% 51.25%
=======================================
Files 273 273
Lines 24651 24651
=======================================
Hits 12636 12636
Misses 11229 11229
Partials 786 786 ☔ View full report in Codecov by Sentry. |
| Expect(os.Setenv("CLOUD_PROVIDER_AZURE_LABEL", "azure-ci")).To(Succeed()) | ||
| } | ||
|
|
||
| if flavor == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these changes related to the new templates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, without this then any run passing the kubetest.use-ci-artifacts or kubetest.use-pr-artifacts flags to the e2e binary will only use the vanilla ci-version/custom-builds template.
|
/lgtm |
|
LGTM label has been added. Git tree hash: f7f2e8e8bf0ed68ac520828ffd5eb4f24158f1da
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold for all the jobs to make sure this doesn't break anything. |
|
tests are green! /hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds new test templates that describe clusters with DRA enabled for CI versions and custom builds of Kubernetes. A forthcoming test-infra PR will create a new periodic job to run the k/k DRA e2e tests using these templates.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: