Skip to content

Add "cluster" type to subnet role validation #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add "cluster" type to subnet role validation #5133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1beta1/types_class.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ type SubnetClassSpec struct {
Name string `json:"name"`

// Role defines the subnet role (eg. Node, ControlPlane)
// +kubebuilder:validation:Enum=node;control-plane;bastion;all
// +kubebuilder:validation:Enum=node;control-plane;bastion;cluster
Copy link
Contributor

@nojnhuh nojnhuh Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is something we'd technically have to call a breaking change if all is no longer valid when it was before. Maybe we have more wiggle room here if all was never functional anyway?

Copy link
Contributor Author

@mboersma mboersma Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of that--someone may have read the source code to figure out that "all" would pass validation. But AFAICT there is no code that handles SubnetRole("all"), no tests around that, and no constant defined for it, so it was not intentionally functional and didn't act as SubnetCluster is intended to.

Copy link
Contributor

@nojnhuh nojnhuh Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @LochanRn

Role SubnetRole `json:"role"`

// CIDRBlocks defines the subnet's address space, specified as one or more address prefixes in CIDR notation.
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_azureclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ spec:
- node
- control-plane
- bastion
- all
- cluster
type: string
routeTable:
description: RouteTable defines the route table that should
Expand Down Expand Up @@ -1057,7 +1057,7 @@ spec:
- node
- control-plane
- bastion
- all
- cluster
type: string
routeTable:
description: RouteTable defines the route table that should
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_azureclustertemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ spec:
- node
- control-plane
- bastion
- all
- cluster
type: string
securityGroup:
description: SecurityGroup defines the NSG (network
Expand Down Expand Up @@ -698,7 +698,7 @@ spec:
- node
- control-plane
- bastion
- all
- cluster
type: string
securityGroup:
description: SecurityGroup defines the NSG (network
Expand Down