-
Notifications
You must be signed in to change notification settings - Fork 460
use correct image for Tilt #5138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @nawazkh |
|
/kind bug |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5138 +/- ##
=======================================
Coverage 51.25% 51.25%
=======================================
Files 273 273
Lines 24651 24651
=======================================
+ Hits 12634 12636 +2
+ Misses 11231 11229 -2
Partials 786 786 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 4c1cad7451b83a18e3e63f9c2a4a711383c05ef2
|
willie-yao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
This change fixes the following warning when loading Tilt, which causes the hot-reloading not to propagate local changes to the live CAPZ controller manager Pod:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: