wire up otel tracing to track2 Azure SDK #5144
Merged
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
Contributor
Author
|
/assign @mboersma |
nojnhuh
force-pushed
the
sdk-tracing
branch
from
9102a28 to
4113129
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5144 +/- ##
==========================================
+ Coverage 51.24% 51.36% +0.11%
==========================================
Files 273 273
Lines 24659 24676 +17
==========================================
+ Hits 12637 12674 +37
+ Misses 11236 11212 -24
- Partials 786 790 +4 ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 6e6a87ec3b5e29ffbc0e1da8f0844b3feaaf4956
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When looking into #1077 I noticed that I couldn't see any Azure HTTP calls in the Jaeger UI. This PR adds the necessary wiring to make those traces from the Azure SDK available that must have been lost when we migrated to the track2 SDK.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
I don't really know if this is all totally "correct" or "the right way to do things" but I at least see the traces showing up which I think is worthwhile incremental progress.
TODOs:
Release note: