-
Notifications
You must be signed in to change notification settings - Fork 459
conditional added to tilt-up to check az #5335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
conditional added to tilt-up to check az #5335
Conversation
|
|
|
Welcome @brettearle! |
|
Hi @brettearle. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @nawazkh @willie-yao |
|
/ok-to-test |
|
Hey @brettearle 👋🏼 , how is this PR coming along ? |
|
Please feel free to open this PR when working. Closing it for now |
|
@nawazkh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Back on board. |
|
@brettearle: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Will go through and check everything is working again |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5335 +/- ##
==========================================
- Coverage 52.43% 44.64% -7.79%
==========================================
Files 272 279 +7
Lines 29401 25244 -4157
==========================================
- Hits 15417 11271 -4146
+ Misses 13178 13150 -28
- Partials 806 823 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5291
Special notes for your reviewer:
TODOs:
Release note: