- 
                Notifications
    You must be signed in to change notification settings 
- Fork 460
Perform nil check on old lb in azurecluster_validation.go #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /cc @willie-yao | 
24d10da    to
    3c00cc1      
    Compare
  
    | Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@           Coverage Diff           @@
##             main    #5378   +/-   ##
=======================================
  Coverage   52.44%   52.44%           
=======================================
  Files         272      272           
  Lines       29349    29349           
=======================================
  Hits        15391    15391           
  Misses      13152    13152           
  Partials      806      806           ☔ View full report in Codecov by Sentry. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-cluster-api-provider-azure-e2e-optional
Will approve once double-checking the test passes
| LGTM label has been added. Git tree hash: a9cd98bfccb1c5301722e57cda720ec8e3cf56be | 
| /approve It would be good to get some runs of this over the weekend, so I'll just approve and feel free to remove the hold once the test passes. | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
| /hold cancel | 
What type of PR is this?
/kind bug
What this PR does / why we need it:
oldlb in thevalidateAPIServerLB()function to avoid any nil pointer errors.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # private cluster tests
Special notes for your reviewer:
TODOs:
Release note: