Skip to content

Perform nil check on old lb in azurecluster_validation.go #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2025
Merged

Perform nil check on old lb in azurecluster_validation.go #5378

merged 1 commit into from
Jan 18, 2025

Conversation

@nawazkh
Copy link
Member

@nawazkh nawazkh commented Jan 17, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:

  • Thanks @willie-yao for finding the bug!
  • This PR adds a nil check on the old lb in the validateAPIServerLB() function to avoid any nil pointer errors.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # private cluster tests

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

perform nil check on private lb

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2025
@nawazkh
Copy link
Member Author

nawazkh commented Jan 17, 2025

/cc @willie-yao

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2025
@nawazkh nawazkh changed the title perform nil check on old lb Perform nil check on old lb in azurecluster_validation.go Jan 17, 2025
@codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.44%. Comparing base (8b8ba05) to head (3c00cc1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
api/v1beta1/azurecluster_validation.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5378   +/-   ##
=======================================
  Coverage   52.44%   52.44%           
=======================================
  Files         272      272           
  Lines       29349    29349           
=======================================
  Hits        15391    15391           
  Misses      13152    13152           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

willie-yao
willie-yao reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/test pull-cluster-api-provider-azure-e2e-optional

Will approve once double-checking the test passes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9cd98bfccb1c5301722e57cda720ec8e3cf56be

@willie-yao
Copy link
Contributor

/approve
/hold

It would be good to get some runs of this over the weekend, so I'll just approve and feel free to remove the hold once the test passes.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@willie-yao
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit e83a5da into kubernetes-sigs:main Jan 18, 2025
23 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 18, 2025
@nawazkh nawazkh deleted the private-lb-bug branch January 18, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willie-yao willie-yao willie-yao left review comments

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

Assignees

@willie-yao willie-yao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

3 participants

@nawazkh @k8s-ci-robot @willie-yao