Skip to content

[release-1.17] Bump CAPI to v1.8.10 in dev and test code #5442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

[release-1.17] Bump CAPI to v1.8.10 in dev and test code #5442

merged 1 commit into from
Mar 21, 2025

Conversation

@mboersma
Copy link
Contributor

@mboersma mboersma commented Feb 19, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Makes some changes that I forgot to include in the previous v1.8.10 PR. 🤦🏻

Which issue(s) this PR fixes:

Refs #5437

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 19, 2025
@codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.40%. Comparing base (22a32cd) to head (511e13c).
Report is 9 commits behind head on release-1.17.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.17    #5442   +/-   ##
=============================================
  Coverage         52.40%   52.40%           
=============================================
  Files               273      273           
  Lines             29185    29185           
=============================================
  Hits              15294    15294           
  Misses            13090    13090           
  Partials            801      801

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mboersma
Copy link
Contributor Author

/retest

@nawazkh
Copy link
Member

nawazkh commented Mar 19, 2025

/test pull-cluster-api-provider-azure-e2e-v1beta1

@nawazkh
Copy link
Member

nawazkh commented Mar 20, 2025

Random flake?
/retest

@nawazkh
Copy link
Member

nawazkh commented Mar 20, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d1647749249bbfa9239e9e2ea809a5595326f49

@nawazkh
Copy link
Member

nawazkh commented Mar 20, 2025

/approve

2 similar comments
@nawazkh
Copy link
Member

nawazkh commented Mar 20, 2025

/approve

@willie-yao
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nawazkh, willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-test-v1beta1 511e13c link unknown /test pull-cluster-api-provider-azure-test-v1beta1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nawazkh
Copy link
Member

nawazkh commented Mar 20, 2025 •
edited
Loading

I ran the test pull-cluster-api-provider-azure-test-v1beta1 on this branch locally and it passed. We can ignore the signal from pull-cluster-api-provider-azure-test-v1beta1 since it is failing on golangci-lint error..

❯ ./scripts/ci-test.sh
make: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-go
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/controller-gen-v0.15.0 \
	paths=./api/... \
	paths=./exp/api/... \
	object:headerFile=./hack/boilerplate/boilerplate.generatego.txt
go generate ./...
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-manifests
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/controller-gen-v0.15.0 \
	paths=./api/... \
	paths=./exp/api/... \
	crd:crdVersions=v1 \
	rbac:roleName=base-manager-role \
	output:crd:dir=config/crd/bases \
	output:webhook:dir=config/webhook \
	webhook
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/controller-gen-v0.15.0 \
	paths=./ \
	paths=./controllers/... \
	paths=./exp/controllers/... \
	output:rbac:dir=config/rbac \
	rbac:roleName=base-manager-role
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-flavors
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
cp /home/nhkdev/msftcode/cluster-api-provider-azure/_artifacts/calico/release-v3.26.1/manifests/calico-vxlan.yaml templates/addons/calico
cp /home/nhkdev/msftcode/cluster-api-provider-azure/_artifacts/calico/release-v3.26.1/manifests/calico-policy-only.yaml templates/addons/calico-ipv6
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/metrics-server > templates/addons/metrics-server/metrics-server.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico > templates/addons/calico.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico-ipv6 > templates/addons/calico-ipv6.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico-dual-stack > templates/addons/calico-dual-stack.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/azure-cni-v1 > templates/addons/azure-cni-v1.yaml
./hack/gen-flavors.sh
make[2]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make[2]: Nothing to be done for 'kustomize'.
make[2]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-e2e-templates
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-md-remediation --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-md-remediation.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-kcp-remediation --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-kcp-remediation.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-machine-pool --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-machine-pool.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-node-drain --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-node-drain.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-upgrades --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-upgrades.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-kcp-scale-in --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-kcp-scale-in.yaml
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-addons
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
cp /home/nhkdev/msftcode/cluster-api-provider-azure/_artifacts/calico/release-v3.26.1/manifests/calico-vxlan.yaml templates/addons/calico
cp /home/nhkdev/msftcode/cluster-api-provider-azure/_artifacts/calico/release-v3.26.1/manifests/calico-policy-only.yaml templates/addons/calico-ipv6
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/metrics-server > templates/addons/metrics-server/metrics-server.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico > templates/addons/calico.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico-ipv6 > templates/addons/calico-ipv6.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico-dual-stack > templates/addons/calico-dual-stack.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/azure-cni-v1 > templates/addons/azure-cni-v1.yaml
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-aso-crds
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
curl -fSsL "https://github.com/Azure/azure-service-operator/releases/download/v2.8.0/azureserviceoperator_customresourcedefinitions_v2.8.0.yaml" | \
	/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/yq-v4.35.2 e '. | select(.metadata.name == "resourcegroups.resources.azure.com" or  .metadata.name == "natgateways.network.azure.com" or  .metadata.name == "managedclusters.containerservice.azure.com" or  .metadata.name == "managedclustersagentpools.containerservice.azure.com" or  .metadata.name == "bastionhosts.network.azure.com" or  .metadata.name == "virtualnetworks.network.azure.com" or  .metadata.name == "virtualnetworkssubnets.network.azure.com" or  .metadata.name == "privateendpoints.network.azure.com" or  .metadata.name == "fleetsmembers.containerservice.azure.com" or  .metadata.name == "extensions.kubernetesconfiguration.azure.com" or false)' - | \
	sed 's/\$\$/$$$$/g' \
	> config/aso/crds.yaml
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
./hack/lint-latest.sh
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/golangci-lint-v1.55.2 run -v --timeout=8m0s --print-resources-usage
INFO [config_reader] Config search paths: [./ /home/nhkdev/msftcode/cluster-api-provider-azure /home/nhkdev/msftcode /home/nhkdev /home /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 47 linters: [asasalint asciicheck bidichk bodyclose containedctx decorder dogsled dupword durationcheck errcheck errchkjson errorlint execinquery exportloopref gci ginkgolinter goconst gocritic gocyclo godot gofmt goimports goprintffuncname gosec gosimple govet importas ineffassign loggercheck misspell nakedret nilerr noctx nolintlint nosprintfhostport predeclared reassign revive rowserrcheck staticcheck stylecheck thelper unconvert unparam unused usestdlibvars whitespace]
INFO [loader] Using build tags: [e2e]
INFO [loader] Go packages loading at mode 575 (imports|types_sizes|compiled_files|deps|exports_file|files|name) took 13.227183259s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 67.36865ms
INFO [linters_context/goanalysis] analyzers took 1m12.043727036s with top 10 stages: gocritic: 29.310143123s, buildir: 10.443910444s, buildssa: 5.290632288s, goimports: 2.427635576s, gci: 1.539033082s, gofmt: 1.312875938s, gosec: 1.211354847s, errorlint: 1.156333448s, the_only_name: 1.08654475s, S1038: 1.009922503s
INFO [runner] Issues before processing: 666, after processing: 0
INFO [runner] Processors filtering stat (out/in): skip_dirs: 659/659, identifier_marker: 600/600, cgo: 666/666, skip_files: 659/666, autogenerated_exclude: 600/659, exclude-rules: 48/600, filename_unadjuster: 666/666, path_prettifier: 666/666, exclude: 600/600, nolint: 0/48
INFO [runner] processing took 65.830409ms with stages: nolint: 21.871001ms, exclude-rules: 18.309699ms, identifier_marker: 10.023958ms, autogenerated_exclude: 7.861991ms, path_prettifier: 6.157759ms, skip_dirs: 1.389902ms, skip_files: 96.088µs, cgo: 88.337µs, filename_unadjuster: 26.076µs, max_same_issues: 1.509µs, fixer: 677ns, sort_results: 610ns, exclude: 532ns, uniq_by_line: 519ns, severity-rules: 429ns, diff: 415ns, source_code: 249ns, max_from_linter: 234ns, path_shortener: 156ns, max_per_file_from_linter: 148ns, path_prefixer: 120ns
INFO [runner] linters took 7.526673587s with stages: goanalysis_metalinter: 7.46070991s
INFO File cache stats: 148 entries of total size 1.8MiB
INFO Memory: 197 samples, avg is 659.4MB, max is 3350.6MB
INFO Execution took 20.833378372s
KUBEBUILDER_ASSETS="/home/nhkdev/.local/share/kubebuilder-envtest/k8s/1.31.0-linux-amd64" go test ./... -race
?   	sigs.k8s.io/cluster-api-provider-azure	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/api/v1alpha1	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/mock_azure	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/api/v1beta1	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/converters	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/azure/scope/mocks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/agentpools/mock_agentpools	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/aso/mock_aso	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/async/mock_async	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/scope	1.394s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/scope/strategies/machinepool_deployments	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/agentpools	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/aksextensions	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/aso	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/async	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/availabilitysets/mock_availabilitysets	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/disks/mock_disks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/groups/mock_groups	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/identities	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/identities/mock_identities	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/inboundnatrules/mock_inboundnatrules	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/loadbalancers/mock_loadbalancers	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/managedclusters/mock_managedclusters	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/natgateways/mock_natgateways	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/availabilitysets	1.192s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/bastionhosts	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/disks	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/fleetsmembers	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/groups	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/inboundnatrules	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/loadbalancers	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/managedclusters	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/natgateways	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/networkinterfaces/mock_networkinterfaces	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/privatedns/mock_privatedns	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/privateendpoints/mock_privateendpoints	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/publicips/mock_publicips	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/resourcehealth/mock_resourcehealth	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/networkinterfaces	1.175s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/privatedns	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/privateendpoints	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/publicips	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/resourcehealth	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/resourceskus/mock_resourceskus	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/resourceskus	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/roleassignments/mock_roleassignments	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/routetables/mock_routetables	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/roleassignments	1.179s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/routetables	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/scalesets/mock_scalesets	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/scalesets	1.136s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/scalesetvms/mock_scalesetvms	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/securitygroups/mock_securitygroups	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/subnets/mock_subnets	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/tags/mock_tags	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/scalesetvms	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/securitygroups	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/subnets	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/tags	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualmachineimages/mock_virtualmachineimages	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualmachineimages	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualmachines/mock_virtualmachines	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualnetworks/mock_virtualnetworks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/vmextensions/mock_vmextensions	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/vnetpeerings/mock_vnetpeerings	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualmachines	1.165s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualnetworks	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/vmextensions	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/vnetpeerings	(cached)
?   	sigs.k8s.io/cluster-api-provider-azure/exp	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/exp/controllers/mocks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/feature	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/hack/boilerplate/test	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/internal/test	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/internal/test/matchers/gomock	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/internal/test/mock_log	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/internal/test/record	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/pkg/cloudtest	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/pkg/coalescing/mocks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/pkg/ot	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/pkg/record	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/cache/ttllru/mocks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/aso	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/generators	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/identity	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/slice	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/version	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/controllers	9.832s
ok  	sigs.k8s.io/cluster-api-provider-azure/exp/api/v1beta1	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/exp/controllers	8.683s
ok  	sigs.k8s.io/cluster-api-provider-azure/internal/test/env	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/internal/test/matchers/gomega	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/pkg/coalescing	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/pkg/mutators	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/azure	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/cache/ttllru	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/futures	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/maps	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/reconciler	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/ssh	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/system	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/tele	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/versions	(cached)
ok  	sigs.k8s.io/cluster-api-provider-azure/util/webhook	(cached)
make: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'

@nawazkh nawazkh merged commit 81f203f into kubernetes-sigs:release-1.17 Mar 21, 2025
16 of 18 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@nawazkh nawazkh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mboersma @nawazkh @k8s-ci-robot @willie-yao