Skip to content

Conversation

@willie-yao
Copy link
Contributor

@willie-yao willie-yao commented Mar 25, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR follows #5428 and bumps some missed parts of ASO to v2.11.0, as pointed out here: Azure/azure-service-operator#4647 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Update ASO CRDs to v2.11.0

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Mar 25, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 25, 2025
@nawazkh
Copy link
Member

nawazkh commented Mar 25, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f488260d5f1162685ef4f66ea50e967a0d8e32b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.57%. Comparing base (a733756) to head (511e16f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5512   +/-   ##
=======================================
  Coverage   52.57%   52.57%           
=======================================
  Files         272      272           
  Lines       29470    29470           
=======================================
+ Hits        15493    15495    +2     
+ Misses      13169    13167    -2     
  Partials      808      808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rbjorklin
Copy link

Thank you for the prompt action! I have been eagerly awaiting the v1.19.0 release because it includes v2.11.0 so that I may use the secretExpressions feature! If possible I would really appreciate a v1.19.1 release once this has been merged 🙏

@nawazkh
Copy link
Member

nawazkh commented Mar 25, 2025

/cherry-pick release-1.19

@k8s-infra-cherrypick-robot

@nawazkh: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 25, 2025
@nawazkh
Copy link
Member

nawazkh commented Mar 25, 2025

/test pull-cluster-api-provider-azure-e2e

@willie-yao
Copy link
Contributor Author

/retest

1 similar comment
@nawazkh
Copy link
Member

nawazkh commented Mar 25, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 920697c into kubernetes-sigs:main Mar 26, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Mar 26, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 26, 2025
@k8s-infra-cherrypick-robot

@nawazkh: new pull request created: #5516

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants