Skip to content

Conversation

@nawazkh
Copy link
Member

@nawazkh nawazkh commented Mar 26, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2025
@nawazkh
Copy link
Member Author

nawazkh commented Mar 26, 2025

/cc @willie-yao @Jont828

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.57%. Comparing base (763e276) to head (e1f223b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5518   +/-   ##
=======================================
  Coverage   52.57%   52.57%           
=======================================
  Files         272      272           
  Lines       29470    29470           
=======================================
+ Hits        15493    15495    +2     
+ Misses      13169    13167    -2     
  Partials      808      808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


### Documentation

- Updating the roadmap to align with our current timeline and future milestones ([#5514](https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/5514), [@k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably vote to manually remove this documentation section, as it isn't really relevant to the v1.19.1 bits that we're releasing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably innocuous Documentation addition imo if we look at this patch release as any other patch release.
But happy to remove it nonetheless!

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d7c0dc6d5f1a1c361cdac50475f5fd768c5ab5e0

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,willie-yao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b4dea42 into kubernetes-sigs:main Mar 26, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Mar 26, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 26, 2025
@nawazkh nawazkh deleted the nhk_v1.19.1 branch March 26, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants