Bump golangci-lint to v1.64.8 #5531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/cleanup
mboersma
commented
Mar 31, 2025
| - revive # better version of golint | ||
| - staticcheck # some of staticcheck's rules | ||
| - stylecheck # another replacement for golint | ||
| - tenv # using os.Setenv instead of t.Setenv in tests |
There was a problem hiding this comment.
tenv was deprecated and its functionality replaced by usetesting.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2ccf7ed6bf24fb8b7802497fb2910f5df383ec5f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5531 +/- ##
=======================================
Coverage 52.61% 52.61%
=======================================
Files 272 272
Lines 29485 29485
=======================================
Hits 15513 15513
Misses 13165 13165
Partials 807 807 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bumps golangci-lint to v1.64.8. I didn't go for v2.0.2 because it seemed potentially more disruptive; we can follow on with those changes later.
Which issue(s) this PR fixes:
N/A, but I've been having trouble getting the current linter ever to pass locally: it just times out. This version seems to work, and quickly. Maybe something got fixed. 🤷
Special notes for your reviewer:
TODOs:
Release note: