-
Notifications
You must be signed in to change notification settings - Fork 460
Add test coverage for agentpooladopt controller #5535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for agentpooladopt controller #5535
Conversation
dfe2dec to
8bd1b4b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5535 +/- ##
==========================================
+ Coverage 52.60% 52.93% +0.32%
==========================================
Files 272 272
Lines 29485 29485
==========================================
+ Hits 15511 15607 +96
+ Misses 13167 13061 -106
- Partials 807 817 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8bd1b4b to
f103e8b
Compare
|
/hold |
Signed-off-by: Troy Connor <[email protected]>
f103e8b to
b3873a8
Compare
|
/hold cancel The test would stop early in the Reconcile method because it had OwnerReferences on it. Now it creates the machinePool resource and gets validated through the test. |
|
/lgtm Hi @troy0820 ! Thank you for adding this. Great start to add more cases. |
|
LGTM label has been added. Git tree hash: bd18247c35d2790ed7415a6c26d0d823abe962df
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nawazkh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah I fell behind but I plan on it. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds testing to the controllers package
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Part of #3649
Special notes for your reviewer:
TODOs:
Release note: