Skip to content

Conversation

@k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5540

/assign nojnhuh

fixes potential OOM due to tracing (even if tracing not enabled)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from mboersma and nojnhuh April 4, 2025 22:53
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 4, 2025
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.54%. Comparing base (1c994c5) to head (a2c3b6d).
Report is 3 commits behind head on release-1.19.

Files with missing lines Patch % Lines
pkg/ot/traces.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.19    #5545      +/-   ##
================================================
- Coverage         52.61%   52.54%   -0.07%     
================================================
  Files               272      272              
  Lines             29485    29474      -11     
================================================
- Hits              15513    15488      -25     
- Misses            13165    13184      +19     
+ Partials            807      802       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh
Copy link
Contributor

nojnhuh commented Apr 4, 2025

/kind bug
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 81b57112ccc8275a52dcbf34f86ea98660be4466

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit da7911b into kubernetes-sigs:release-1.19 Apr 5, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants