Skip to content

Bump Go toolchain to v1.23.8 #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Bump Go toolchain to v1.23.8 #5561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
ARG ARCH

# Build the manager binary
FROM golang:1.22 AS builder
FROM golang:1.23 AS builder
WORKDIR /workspace

# Run this with docker build --build_arg $(go env GOPROXY) to override the goproxy
Expand Down
2 changes: 1 addition & 1 deletion Tiltfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def validate_auth():

tilt_helper_dockerfile_header = """
# Tilt image
FROM golang:1.22 AS tilt-helper
FROM golang:1.23 AS tilt-helper
# Support live reloading with Tilt
RUN wget --output-document /restart.sh --quiet https://raw.githubusercontent.com/windmilleng/rerun-process-wrapper/master/restart.sh && \
wget --output-document /start.sh --quiet https://raw.githubusercontent.com/windmilleng/rerun-process-wrapper/master/start.sh && \
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module sigs.k8s.io/cluster-api-provider-azure

go 1.22.7
go 1.23.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for anyone who might be looking here when updating Go to the next version: it probably doesn't hurt to also bump the image used in cloudbuild.yaml like in #5715. The complete list of available tags can be found with this command:

curl https://gcr.io/v2/k8s-staging-test-infra/gcb-docker-gcloud/tags/list | jq .tags

Then to figure out the go version:

docker run --rm --entrypoint go gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20250116-2a05ea7e3d version

Obviously not critical that this stays up to date since we hadn't updated for four years, but probably a good idea not to push the limit.


toolchain go1.22.12
toolchain go1.23.8

require (
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.17.0
Expand Down
4 changes: 3 additions & 1 deletion hack/tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module sigs.k8s.io/cluster-api-provider-azure/hack/tools

go 1.21
go 1.23.0

toolchain go1.23.8

require sigs.k8s.io/cluster-api/hack/tools v0.0.0-20240116152609-a150f715f5a6

Expand Down
Loading